@@ -242,3 +242,9 @@
// NO-WARN-ATOMIC: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}}
"-Werror=atomic-alignment" {{.*}} "-Wno-error=atomic-alignment"
// NO-WARN-ATOMIC-NOT: clang{{.*}} "-triple" "x86_64-unknown-linux-gnu" {{.*}}
"-Werror=atomic-alignment"
// NO-WARN-ATOMIC-
@@ -1026,6 +1026,12 @@ void Clang::AddPreprocessingOptions(Compilation &C,
const JobAction &JA,
CmdArgs.push_back("-dependency-file");
CmdArgs.push_back(DepFile);
}
+// Cmake generates dependency files using all compilation options specified
+// by user
https://github.com/yxsamliu closed
https://github.com/llvm/llvm-project/pull/133456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/133456
>From be4ea80f2431bff0c017df3aef9f260dddfa9ccc Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Fri, 28 Mar 2025 11:30:39 -0400
Subject: [PATCH] [HIP] Claim --offloading-compress for -M
Cmake automatical
@@ -242,3 +242,9 @@
// NO-WARN-ATOMIC: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}}
"-Werror=atomic-alignment" {{.*}} "-Wno-error=atomic-alignment"
// NO-WARN-ATOMIC-NOT: clang{{.*}} "-triple" "x86_64-unknown-linux-gnu" {{.*}}
"-Werror=atomic-alignment"
// NO-WARN-ATOMIC-
https://github.com/jhuber6 approved this pull request.
Didn't notice the indentation, LGTM.
https://github.com/llvm/llvm-project/pull/133456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
@@ -1026,6 +1026,12 @@ void Clang::AddPreprocessingOptions(Compilation &C,
const JobAction &JA,
CmdArgs.push_back("-dependency-file");
CmdArgs.push_back(DepFile);
}
+// Cmake generates dependency files using all compilation options specified
+// by user
yxsamliu wrote:
> > > Why does this only cause warnings when it makes dependency files?
> >
> >
> > Because `--offloading-compress` is parsed by offload bundler and offload
> > wrapper actions when creating job actions. There is no action to parse them
> > in the compilation that only generat
jhuber6 wrote:
> > Why does this only cause warnings when it makes dependency files?
>
> Because `--offloading-compress` is parsed by offload bundler and offload
> wrapper actions when creating job actions. There is no action to parse them
> in the compilation that only generates dependency fi
yxsamliu wrote:
> Why does this only cause warnings when it makes dependency files?
Because `--offloading-compress` is parsed by offload bundler and offload
wrapper actions when creating job actions. There is no action to parse them in
the compilation that only generates dependency files.
> I
https://github.com/jhuber6 commented:
Why does this only cause warnings when it makes dependency files? If we can
check whether or not it's HIP, then why isn't any of the HIP argument parsing
happening?
https://github.com/llvm/llvm-project/pull/133456
__
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
Cmake automatically generates dependency files with all compilation options
provided by users. When users use `--offload-compress` for HIP compilation, it
causes warnings when cmake generates depe
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
Cmake automatically generates dependency files with all compilation options
provided by users. When users use `--offload-compress` for HIP compilation, it
causes warnings when cmake generates dependency
https://github.com/yxsamliu edited
https://github.com/llvm/llvm-project/pull/133456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
14 matches
Mail list logo
