[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-25 Thread via cfe-commits
https://github.com/martinboehme approved this pull request. https://github.com/llvm/llvm-project/pull/112457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-24 Thread Florian Mayer via cfe-commits
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/112457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-24 Thread via cfe-commits
martinboehme wrote: > > I think this is the right change. > > What I don't understand, though, is why you were getting an assert failure > > before. (Which line is the assertion on that failed?) I would have thought > > if you don't dump the nested record, you just get less information. > > Ap

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-23 Thread Florian Mayer via cfe-commits
fmayer wrote: > I think this is the right change. > > What I don't understand, though, is why you were getting an assert failure > before. (Which line is the assertion on that failed?) I would have thought if > you don't dump the nested record, you just get less information. Apparently > not

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-23 Thread via cfe-commits
martinboehme wrote: I think this is the right change. What I don't understand, though, is why you were getting an assert failure before. (Which line is the assertion on that failed?) I would have thought if you don't dump the nested record, you just get less information. Apparently not so? >

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-22 Thread Florian Mayer via cfe-commits
fmayer wrote: > I would suggest a brief comment explaining the choice not to filter. I'm not sure I understand. There wasn't a choice to filter before, there was just the (incorrect) assumption that we don't have nested `RecordStorageLocation`, leading to a crash. https://github.com/llvm/llvm

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-22 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. I would suggest a brief comment explaining the choice not to filter. https://github.com/llvm/llvm-project/pull/112457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-15 Thread Florian Mayer via cfe-commits
fmayer wrote: An example dump that is now possible but crashed before ![image](https://github.com/user-attachments/assets/21e4ce35-4bf2-41dd-9a65-32dedb82723a) https://github.com/llvm/llvm-project/pull/112457 ___ cfe-commits mailing list cfe-commits@l

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Florian Mayer (fmayer) Changes We have an internal analysis that uses them, and the HTML dump would fail on the assertion. --- Full diff: https://github.com/llvm/llvm-project/pull/112457.diff 1 Files Affected: - (modified) clang/lib/An

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: Florian Mayer (fmayer) Changes We have an internal analysis that uses them, and the HTML dump would fail on the assertion. --- Full diff: https://github.com/llvm/llvm-project/pull/112457.diff 1 Files Affected: - (modified) cla

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-15 Thread Florian Mayer via cfe-commits
https://github.com/fmayer created https://github.com/llvm/llvm-project/pull/112457 We have an internal analysis that uses them, and the HTML dump would fail on the assertion. >From 4264fe1dfed3fc54f339ad4a769d76158c5ee7d5 Mon Sep 17 00:00:00 2001 From: Florian Mayer Date: Tue, 15 Oct 2024 17: