https://github.com/zixu-w closed https://github.com/llvm/llvm-project/pull/74886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ian-twilightcoder approved this pull request.
https://github.com/llvm/llvm-project/pull/74886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/74886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fhahn approved this pull request.
LGTM, thanks!
For reference, this is breaking llvm-test-suite builds, e.g. see
https://green.lab.llvm.org/green/job/lnt-ctmark-aarch64-Os/15893/console
https://github.com/llvm/llvm-project/pull/74886
_
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Zixu Wang (zixu-w)
Changes
https://github.com/llvm/llvm-project/pull/74676 landed the work to implement
`-fdefine-target-os-macros` and enabled the extension for the Darwin driver.
However it is breaking
https://github.com/zixu-w created
https://github.com/llvm/llvm-project/pull/74886
https://github.com/llvm/llvm-project/pull/74676 landed the work to implement
`-fdefine-target-os-macros` and enabled the extension for the Darwin driver.
However it is breaking some test builds. Leave the extensi