[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls` running on `linaro-g3-03` while building `clang` at step 6 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/4702 Here is the relevant piece of the bui

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-12 Thread via cfe-commits
github-actions[bot] wrote: @Sharjeel-Khan Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-12 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab closed https://github.com/llvm/llvm-project/pull/122540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-12 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab approved this pull request. https://github.com/llvm/llvm-project/pull/122540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-11 Thread Thurston Dang via cfe-commits
https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/122540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-11 Thread Sharjeel Khan via cfe-commits
https://github.com/Sharjeel-Khan updated https://github.com/llvm/llvm-project/pull/122540 >From c8d2c210a98fe0c96d758d538d50fcc0ca61a9ff Mon Sep 17 00:00:00 2001 From: Sharjeel Khan Date: Fri, 10 Jan 2025 20:07:52 + Subject: [PATCH 1/3] Warn when using msan on Android Msan is not supported

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-11 Thread Thurston Dang via cfe-commits
thurstond wrote: > these checks into Toolchains/Linux.cpp so it triggers that code: IMO adding the Android msan check into Toolchains/Linux.cpp would be cleaner because it's: 1) only a 1 or 2 line change (compared with the current ~10 lines) 2) this file handles all the broad compatibility chec

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-11 Thread Sharjeel Khan via cfe-commits
Sharjeel-Khan wrote: I can do it by moving these checks into Toolchains/Linux.cpp so it triggers that code: https://github.com/llvm/llvm-project/blob/2914ba1c01fdc496082197abf7cd35e2af526634/clang/lib/Driver/ToolChains/Linux.cpp#L809-L865. Is this a good solution? https://github.com/llvm/llvm-

[clang] [Driver] Warn when using msan on Android (PR #122540)

2025-01-11 Thread Carlo Cabrera via cfe-commits
carlocab wrote: There is already handling of unsupported sanitisers just above: https://github.com/llvm/llvm-project/blob/77ef5a601ad3827316e412788f609e9141b51e83/clang/lib/Driver/SanitizerArgs.cpp#L523-L530 Is it not possible to incorporate the lack of support for msan on Android there? https