[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

2024-11-27 Thread Haohai Wen via cfe-commits
HaohaiWen wrote: > Adding CLOption to -fprofile-sample-use= suffices. We don't need these > CLJoined aliases. They are for MSVC options that are ported to clang. For > clang-specific options, we don't want to add unneeded aliases. Got it. I checked CL flags with MSVC. You're right. Let me reve

[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

2024-11-27 Thread Fangrui Song via cfe-commits
MaskRay wrote: Adding CLOption to -fprofile-sample-use= suffices. We don't need these CLJoined aliases. They are for MSVC options that are ported to clang. For clang-specific options, we don't want to add unneeded aliases. https://github.com/llvm/llvm-project/pull/117282 ___

[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

2024-11-27 Thread Haohai Wen via cfe-commits
https://github.com/HaohaiWen closed https://github.com/llvm/llvm-project/pull/117282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

2024-11-25 Thread Haohai Wen via cfe-commits
@@ -8484,6 +8484,9 @@ def _SLASH_fp_strict : CLFlag<"fp:strict">, HelpText<"">, Alias, A def _SLASH_fsanitize_EQ_address : CLFlag<"fsanitize=address">, HelpText<"Enable AddressSanitizer">, Alias, AliasArgs<["address"]>; +def : CLJoined<"fno-profile-sample-use">, Alias; ---

[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

2024-11-25 Thread Fangrui Song via cfe-commits
@@ -8484,6 +8484,9 @@ def _SLASH_fp_strict : CLFlag<"fp:strict">, HelpText<"">, Alias, A def _SLASH_fsanitize_EQ_address : CLFlag<"fsanitize=address">, HelpText<"Enable AddressSanitizer">, Alias, AliasArgs<["address"]>; +def : CLJoined<"fno-profile-sample-use">, Alias; ---

[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

2024-11-24 Thread Haohai Wen via cfe-commits
@@ -2660,7 +2660,7 @@ usual build cycle when using sample profilers for optimization: > clang-cl /O2 -gdwarf -gline-tables-only ^ /clang:-fdebug-info-for-profiling /clang:-funique-internal-linkage-names ^ - /fprofile-sample-use=code.prof code.cc /Fe:code /f

[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

2024-11-22 Thread Tim Creech via cfe-commits
https://github.com/tcreech-intel approved this pull request. Looks good to me. https://github.com/llvm/llvm-project/pull/117282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

2024-11-22 Thread Tim Creech via cfe-commits
@@ -2660,7 +2660,7 @@ usual build cycle when using sample profilers for optimization: > clang-cl /O2 -gdwarf -gline-tables-only ^ /clang:-fdebug-info-for-profiling /clang:-funique-internal-linkage-names ^ - /fprofile-sample-use=code.prof code.cc /Fe:code /f

[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

2024-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Haohai Wen (HaohaiWen) Changes Sampling PGO has already been supported on Windows. This patch adds /fprofile-sample-use= /fprofile-sample-use: /fno-profile-sample-use and supports -fprofile-sample-use= for CL. --- Full diff: https:/

[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

2024-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haohai Wen (HaohaiWen) Changes Sampling PGO has already been supported on Windows. This patch adds /fprofile-sample-use= /fprofile-sample-use: /fno-profile-sample-use and supports -fprofile-sample-use= for CL. --- Full diff: https://github

[clang] [Driver] Support fprofile-sample-use= for CL (PR #117282)

2024-11-21 Thread Haohai Wen via cfe-commits
https://github.com/HaohaiWen created https://github.com/llvm/llvm-project/pull/117282 Sampling PGO has already been supported on Windows. This patch adds /fprofile-sample-use= /fprofile-sample-use: /fno-profile-sample-use and supports -fprofile-sample-use= for CL. >From 8fbe3ed35afd38e2d7b36a89