[clang] [Driver] Remove identifier with the comment (PR #68351)

2023-10-17 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/68351 >From 4cf784b8e73515c3120793ac0ec1cf59ef6da767 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oct 2023 16:23:58 -0400 Subject: [PATCH] [Driver][NFC] Remove identifier with the comment MaskRay suggested remo

[clang] [Driver] Remove identifier with the comment (PR #68351)

2023-10-17 Thread Fangrui Song via cfe-commits
MaskRay wrote: Add `NFC`? https://github.com/llvm/llvm-project/pull/68351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove identifier with the comment (PR #68351)

2023-10-17 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/68351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove identifier with the comment (PR #68351)

2023-10-17 Thread Brad Smith via cfe-commits
brad0 wrote: @MaskRay Ping. https://github.com/llvm/llvm-project/pull/68351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove identifier with the comment (PR #68351)

2023-10-11 Thread Brad Smith via cfe-commits
brad0 wrote: ping. https://github.com/llvm/llvm-project/pull/68351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove identifier with the comment (PR #68351)

2023-10-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes MaskRay suggested removal of the identifer in a review for another ToolChain so doing the same for the rest. --- Full diff: https://github.com/llvm/llvm-project/pull/68351.diff 8 Files Affected: - (modified) clang/lib/Driver/Tool

[clang] [Driver] Remove identifier with the comment (PR #68351)

2023-10-05 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/68351 MaskRay suggested removal of the identifer in a review for another ToolChain so doing the same for the rest. >From 977aaf66e606f454949edae1d18b14cb06307a51 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oc