[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/99723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/99723 >From 869385fd8d7738b041149d88d5f427b5039c5921 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Mon, 6 May 2024 10:07:52 -0700 Subject: [PATCH 1/3] [Driver] Clean up fp-contract handling in clang driver This

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

https://github.com/zahiraam approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/99723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

https://github.com/MaskRay approved this pull request. The logic is complex and difficult to follow, but the test updates looks good! https://github.com/llvm/llvm-project/pull/99723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

@@ -81,6 +81,20 @@ // RUN: | FileCheck --check-prefix=WARN13 %s // WARN13: warning: overriding '-ffp-model=strict' option with '-fapprox-func' [-Woverriding-option] +// RUN: %clang -### -ffp-model=precise -ffp-contract=off -c %s 2>&1 \ +// RUN: | FileCheck --check-prefix=

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/99723 >From 869385fd8d7738b041149d88d5f427b5039c5921 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Mon, 6 May 2024 10:07:52 -0700 Subject: [PATCH 1/2] [Driver] Clean up fp-contract handling in clang driver This

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

zahiraam wrote: > This is a refreshed version of #91271. Given how long it's been since I > updated that PR, it seemed better to just start fresh. May be #91271 should be closed then, In `Driver/fp-contract.c`, all the `//RUN` lines where you removed the `-Werror` should now have `//WARN` chec

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

@@ -10,18 +10,18 @@ // RUN: %clang -### -fno-fast-math -c %s 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-FPC-ON %s -// RUN: %clang -### -Werror -ffast-math -ffp-contract=on -c %s 2>&1 \ +// RUN: %clang -### -ffast-math -ffp-contract=on -c %s 2>&1 \ MaskR

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

andykaylor wrote: This is a refreshed version of https://github.com/llvm/llvm-project/pull/91271. Given how long it's been since I updated that PR, it seemed better to just start fresh. https://github.com/llvm/llvm-project/pull/99723 ___ cfe-commits

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This change refactors the fp-contract handling in RenderFloatingPointOptions in the clang driver code and fixes some inconsistencies in the way warnings are reported for changes in the fp-contract behavior.

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Andy Kaylor (andykaylor) Changes This change refactors the fp-contract handling in RenderFloatingPointOptions in the clang driver code and fixes some inconsistencies in the way warnings are reported for changes in the fp-contract beh

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #99723)

https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/99723 This change refactors the fp-contract handling in RenderFloatingPointOptions in the clang driver code and fixes some inconsistencies in the way warnings are reported for changes in the fp-contract behavior. >