https://github.com/benshi001 closed
https://github.com/llvm/llvm-project/pull/111798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/111798
>From 45b72f225a663c96652955347f9e2c2fb5044335 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Thu, 10 Oct 2024 15:31:19 +0800
Subject: [PATCH 1/2] [clang][Driver][AVR] Reject c/c++ compilation for avr1
devices
@@ -598,6 +598,8 @@ WebAssembly Support
AVR Support
^^^
+- Reject C/C++ compilation for avr1 devices which has no SRAM.
DavidSpickett wrote:
"which have no", since devices is plural.
https://github.com/llvm/llvm-project/pull/111798
__
https://github.com/DavidSpickett approved this pull request.
LGTM with the wording fixed.
https://github.com/llvm/llvm-project/pull/111798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/111798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benshi001 wrote:
> Please add a release note in
> https://clang.llvm.org/docs/ReleaseNotes.html#avr-support
> (`clang/docs/ReleaseNotes.rst`).
>
> Otherwise, this looks good to me.
The note is added. Thanks!
https://github.com/llvm/llvm-project/pull/111798
___
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/111798
>From 45b72f225a663c96652955347f9e2c2fb5044335 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Thu, 10 Oct 2024 15:31:19 +0800
Subject: [PATCH] [clang][Driver][AVR] Reject c/c++ compilation for avr1
devices
avr
DavidSpickett wrote:
Please add a release note in
https://clang.llvm.org/docs/ReleaseNotes.html#avr-support
(`clang/docs/ReleaseNotes.rst`).
Otherwise, this looks good to me.
https://github.com/llvm/llvm-project/pull/111798
___
cfe-commits mailing l
https://github.com/jacquesguan approved this pull request.
https://github.com/llvm/llvm-project/pull/111798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benshi001 wrote:
> ```
> �_bk;t=1728546187607�Failed Tests (1):
> �_bk;t=1728546187607� Clang :: Driver/hip-partial-link.hip
> ```
>
> And the CI test failure is this, the reporting is not great because we run
> check- targets one after another. This test was already failing on main.
>
> If i
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList
&DriverArgs,
void AVRToolChain::addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const {
+ // Reject C
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList
&DriverArgs,
void AVRToolChain::addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const {
+ // Reject C
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList
&DriverArgs,
void AVRToolChain::addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const {
+ // Reject C
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList
&DriverArgs,
void AVRToolChain::addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const {
+ // Reject C
benshi001 wrote:
> Thanks for getting to this I had forgotten I raised that issue.
>
> You should move your commit's message into the PR description, as the PR
> description is what's used for the final commit when we merge this.
Thanks. I have update my PR description according to my commit m
https://github.com/benshi001 edited
https://github.com/llvm/llvm-project/pull/111798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/111798
>From c50c44044546fd9d67dab56b1f88b2e83557656f Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Thu, 10 Oct 2024 15:31:19 +0800
Subject: [PATCH] [clang][Driver][AVR] Reject c/c++ compilation for avr1
devices
avr
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/111798
>From 259282836aa24e59b94dba0572faa2180520028d Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Thu, 10 Oct 2024 15:31:19 +0800
Subject: [PATCH] [Driver][AVR] Reject c/c++ compilation for avr1 devices
avr-gcc als
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/111798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
```
_bk;t=1728546187607Failed Tests (1):
_bk;t=1728546187607 Clang :: Driver/hip-partial-link.hip
```
And the CI test failure is this, the reporting is not great because we run
check- targets one after another. This test was already failing on main.
If it fails again d
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList
&DriverArgs,
void AVRToolChain::addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const {
+ // Reject C
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/111798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList
&DriverArgs,
void AVRToolChain::addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const {
+ // Reject C
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList
&DriverArgs,
void AVRToolChain::addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const {
+ // Reject C
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList
&DriverArgs,
void AVRToolChain::addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const {
+ // Reject C
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList
&DriverArgs,
void AVRToolChain::addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const {
+ // Reject C
https://github.com/DavidSpickett commented:
Thanks for getting to this I had forgotten I raised that issue.
You should move your commit's message into the PR description, as the PR
description is what's used for the final commit when we merge this.
https://github.com/llvm/llvm-project/pull/111
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/111798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList
&DriverArgs,
void AVRToolChain::addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const {
+ // Reject C
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/111798
>From 437fbfb157882469ffa576a023f39399fc82f69c Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Thu, 10 Oct 2024 15:31:19 +0800
Subject: [PATCH] [Driver][AVR] Reject c/c++ compilation for avr1 devices
avr-gcc als
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ben Shi (benshi001)
Changes
avr-gcc also rejects since these devices has no SRAM.
---
Full diff: https://github.com/llvm/llvm-project/pull/111798.diff
2 Files Affected:
- (modified) clang/lib/Driver/ToolChains/AVR.cpp (+8)
- (modified)
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Ben Shi (benshi001)
Changes
avr-gcc also rejects since these devices has no SRAM.
---
Full diff: https://github.com/llvm/llvm-project/pull/111798.diff
2 Files Affected:
- (modified) clang/lib/Driver/ToolChains/AVR.cpp (+8)
- (mo
https://github.com/benshi001 created
https://github.com/llvm/llvm-project/pull/111798
avr-gcc also rejects since these devices has no SRAM.
>From 438b4ed8556445d1950d7878660d893350fa27a6 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Thu, 10 Oct 2024 15:31:19 +0800
Subject: [PATCH] [Driver][AVR]
33 matches
Mail list logo
