[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/72478 >From 5bfc0608073cd699e42a23b07d68b4572a14fcbd Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Wed, 15 Nov 2023 22:06:46 -0800 Subject: [PATCH 1/5] [CodeGen] Add conditional to module cloning in bitcode linkin

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/72478 >From 7d2ee902f1fb1dc0cd355b4b51fda32309f45ccb Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Wed, 15 Nov 2023 22:06:46 -0800 Subject: [PATCH 1/5] [CodeGen] Add conditional to module cloning in bitcode linkin

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

@@ -251,32 +255,50 @@ bool BackendConsumer::LinkInModules(llvm::Module *M, bool ShouldLinkFiles) { } CurLinkModule = LM.Module.get(); - -// TODO: If CloneModule() is updated to support cloning of unmaterialized -// modules, we can remove this bool Err;

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/72478 >From 3a2a066eeadce6b8f3cd5645965ffe564e68fba3 Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Wed, 15 Nov 2023 22:06:46 -0800 Subject: [PATCH 1/3] [CodeGen] Add conditional to module cloning in bitcode linkin

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

https://github.com/mikerice1969 approved this pull request. LGTM. It fixes the performance problems we were seeing. Thanks! https://github.com/llvm/llvm-project/pull/72478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/72478 >From 3a2a066eeadce6b8f3cd5645965ffe564e68fba3 Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Wed, 15 Nov 2023 22:06:46 -0800 Subject: [PATCH 1/2] [CodeGen] Add conditional to module cloning in bitcode linkin

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

@@ -251,32 +255,50 @@ bool BackendConsumer::LinkInModules(llvm::Module *M, bool ShouldLinkFiles) { } CurLinkModule = LM.Module.get(); - -// TODO: If CloneModule() is updated to support cloning of unmaterialized -// modules, we can remove this bool Err;

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c3b9c36f3ab4d9021951a00c9a6798e3fe0a48a5 3a2a066eeadce6b8f3cd5645965ffe564e68fba3 --

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Jacob Lambert (lamb-j) Changes Now that we have a commandline option dictating a second link step, (-relink-builtin-bitcode-postop), we can condition the module creation when linking in bitcode modules. This aims to improve perfor

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Jacob Lambert (lamb-j) Changes Now that we have a commandline option dictating a second link step, (-relink-builtin-bitcode-postop), we can condition the module creation when linking in bitcode modules. This aims to improve performance by

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

https://github.com/lamb-j created https://github.com/llvm/llvm-project/pull/72478 Now that we have a commandline option dictating a second link step, (-relink-builtin-bitcode-postop), we can condition the module creation when linking in bitcode modules. This aims to improve performance by avoi