vvereschaka wrote:
Works fine on my builder. Thank you. I'm going to land this patch.
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vvereschaka wrote:
not a problem, I'll land this patch,
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vgvassilev wrote:
If all good, would you mind landing it? I need to disappear for couple of
hours.
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
vvereschaka wrote:
I would like to do a full rebuild just in case. I'll let you know about the
results.
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
vvereschaka wrote:
@vgvassilev thank you. This patch looks promising, the tests have been passed
successfully with it
```
-- Testing: 21 of 19608 tests, 21 workers --
PASS: Clang-Unit :: Interpreter/./ClangReplInterpreterTests.exe/8/21 (1 of 21)
PASS: Clang-Unit :: Interpreter/./ClangReplInterp
vgvassilev wrote:
Can you try this one:
```diff
diff --git a/clang/unittests/Interpreter/CodeCompletionTest.cpp
b/clang/unittests/Interpreter/CodeCompletionTest.cpp
index cd7fdfa588a5..873fbda32f05 100644
--- a/clang/unittests/Interpreter/CodeCompletionTest.cpp
+++ b/clang/unittests/Interpreter
vgvassilev wrote:
I am testing a fix/workaround. Will send a diff shortly...
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vvereschaka wrote:
I also didn't noticed any related changes with the triple in these commits, but
they were the only related with the interpreter in the failed build. I just
tried to revert them and run these tests again.
https://github.com/llvm/llvm-project/pull/75556
___
vvereschaka wrote:
I tried to revert this commit and two next ones with the warning fixes (they
are related) locally on the builder. The tests have passed successfully after
reverting
These commits have been reverted
* 8c296d58c50902e367f64417948d6e2d43828f36
* 8dd77fa5ae2c20cce903501e9090c663b
vgvassilev wrote:
@vvereschaka, would reverting this PR fix the problem? The error seems
unrelated to the code changes. IIUC it says that we fail to pass the correct
target triple to be able to execute code...
https://github.com/llvm/llvm-project/pull/75556
vgvassilev wrote:
@vvereschaka, thanks for the ping. Will look into this shortly. Feel free to
revert.
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
vvereschaka wrote:
Looks like these changes break the`ClangReplInterpreterTests` unit tests
* https://lab.llvm.org/buildbot/#/builders/119/builds/16346
* https://lab.llvm.org/buildbot/#/builders/60/builds/15188
* Clang-Unit :: Interpreter/./ClangReplInterpreterTests.exe/17/21
* Clang-Unit :: In
https://github.com/vgvassilev closed
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
capfredf wrote:
@vgvassilev the commit message in the original commit isn't very useful. To my
recollection, I wrote more detailed message than `Differential Revision:
https://reviews.llvm.org/D159128`, but I can't find it now. The original
development branch has been deleted. So I rewrote the
https://github.com/capfredf edited
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/capfredf updated
https://github.com/llvm/llvm-project/pull/75556
>From 50d9369cb5144676060a3a6fa0298b3b4a903193 Mon Sep 17 00:00:00 2001
From: Fred Fu
Date: Wed, 13 Dec 2023 22:07:17 -0500
Subject: [PATCH] [ClangRepl] Reland Semantic Code Completion
This patch contains chang
https://github.com/capfredf updated
https://github.com/llvm/llvm-project/pull/75556
>From bade781901b95458b0195952d0879f60c1320607 Mon Sep 17 00:00:00 2001
From: Fred Fu
Date: Wed, 13 Dec 2023 22:07:17 -0500
Subject: [PATCH] [ClangRepl] Reland Semantic Code Completion
This patch contains chang
vgvassilev wrote:
@capfredf ping.
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
capfredf wrote:
@vgvassilev Sure.
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vgvassilev wrote:
@capfredf, can you include the original commit message in the commit and add a
line about what was done to resolve the reason we have reverted it earlier?
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
c
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Fred Fu (capfredf)
Changes
---
Patch is 24.20 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/75556.diff
6 Files Affected:
- (modified) clang/include/clang/Interpreter/CodeCompletion.h (+22-
https://github.com/capfredf edited
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
23 matches
Mail list logo
