[clang] [Clang] show attribute namespace in diagnostics (PR #138519)

2025-05-08 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/138519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] show attribute namespace in diagnostics (PR #138519)

2025-05-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/138519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] show attribute namespace in diagnostics (PR #138519)

2025-05-08 Thread Erich Keane via cfe-commits
@@ -6861,13 +6861,16 @@ ProcessDeclAttribute(Sema &S, Scope *scope, Decl *D, const ParsedAttr &AL, // though they were unknown attributes. if (AL.getKind() == ParsedAttr::UnknownAttribute || !AL.existsInTarget(S.Context.getTargetInfo())) { -S.Diag(AL.getLoc(), -

[clang] [Clang] show attribute namespace in diagnostics (PR #138519)

2025-05-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/138519 >From cbbca4d26b8d00eb103f110c2341fab2e4a2e40d Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 5 May 2025 15:30:14 +0300 Subject: [PATCH 1/2] [Clang] diagnose unknown attribute namespaces --- c

[clang] [Clang] show attribute namespace in diagnostics (PR #138519)

2025-05-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/138519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] show attribute namespace in diagnostics (PR #138519)

2025-05-07 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. As far as the changes go, this LGTM. We can generalize in another PR (which will update some parts of this patch but not enough to be worried we're wasting effort). https://github.com/llvm/llvm-project/pull/138519

[clang] [Clang] show attribute namespace in diagnostics (PR #138519)

2025-05-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/138519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits