[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-06 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118872 >From 30eb50c2fff14d4f79b3f3bd2b36e511bcb2db27 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 5 Dec 2024 22:18:37 +0100 Subject: [PATCH 1/4] [Clang] Warning as error Array Comparisons from C++26 St

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-06 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118872 >From 30eb50c2fff14d4f79b3f3bd2b36e511bcb2db27 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 5 Dec 2024 22:18:37 +0100 Subject: [PATCH 1/3] [Clang] Warning as error Array Comparisons from C++26 St

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. This seems fine to me. Please give folks ~24 hrs to chime in before merging. https://github.com/llvm/llvm-project/pull/118872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-06 Thread Amr Hesham via cfe-commits
@@ -428,6 +428,9 @@ New Compiler Flags - The ``-Warray-compare`` warning has been added to warn about array comparison on versions older than C++20. +- The ``-Warray-compare-cxx26`` warning has been added to warn about array comparison + starting from C++26, this warn is e

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-06 Thread Amr Hesham via cfe-commits
@@ -239,7 +239,7 @@ C++2c implementation status Remove Deprecated Array Comparisons from C++26 https://wg21.link/P2865R6";>P2865R6 - No + Clang 20 AmrDeveloper wrote: Done, thanks https://github.com/llvm/llvm-project/pull/118872 __

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-06 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118872 >From 30eb50c2fff14d4f79b3f3bd2b36e511bcb2db27 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 5 Dec 2024 22:18:37 +0100 Subject: [PATCH 1/3] [Clang] Warning as error Array Comparisons from C++26 St

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-06 Thread Amr Hesham via cfe-commits
@@ -10274,6 +10274,11 @@ def warn_array_comparison : Warning< "to compare array addresses, use unary '+' to decay operands to pointers">, InGroup>; +def warn_array_comparison_cxx26 : Warning< + "comparison between two arrays compare their addresses not their contents; " -

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-06 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118872 >From 30eb50c2fff14d4f79b3f3bd2b36e511bcb2db27 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 5 Dec 2024 22:18:37 +0100 Subject: [PATCH 1/2] [Clang] Warning as error Array Comparisons from C++26 St

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-05 Thread Yanzuo Liu via cfe-commits
@@ -239,7 +239,7 @@ C++2c implementation status Remove Deprecated Array Comparisons from C++26 https://wg21.link/P2865R6";>P2865R6 - No + Clang 20 zwuis wrote: ```suggestion Clang 20 ``` https://github.com/llvm/llvm-project/pull/118872

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-05 Thread Erich Keane via cfe-commits
@@ -428,6 +428,9 @@ New Compiler Flags - The ``-Warray-compare`` warning has been added to warn about array comparison on versions older than C++20. +- The ``-Warray-compare-cxx26`` warning has been added to warn about array comparison + starting from C++26, this warn is e

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-05 Thread Erich Keane via cfe-commits
@@ -10274,6 +10274,11 @@ def warn_array_comparison : Warning< "to compare array addresses, use unary '+' to decay operands to pointers">, InGroup>; +def warn_array_comparison_cxx26 : Warning< + "comparison between two arrays compare their addresses not their contents; " -

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes Starting from C++26 the array comparison warning should converted to an error. Fixes: #117859 --- Full diff: https://github.com/llvm/llvm-project/pull/118872.diff 7 Files Affected: - (modified) clang/d

[clang] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-05 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/118872 Starting from C++26 the array comparison warning should converted to an error. Fixes: #117859 >From 30eb50c2fff14d4f79b3f3bd2b36e511bcb2db27 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 5 Dec 20