zibi2 wrote:
> Actually, a trailing comma in the macro invocation might work too. It’s been
> a while since I last had to deal w/ this.
Yes, it does and I think it's cleaner than my proposal. Thank you.
https://github.com/llvm/llvm-project/pull/84520
___
zibi2 wrote:
I agree the code is not C++17 compliant. An alternative fix would be to compile
this file with `-Wno-c++20-extensions`.
https://github.com/llvm/llvm-project/pull/84520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
Sirraide wrote:
Actually, a trailing comma in the macro invocation might work too. It’s been a
while since I last had to deal w/ this.
https://github.com/llvm/llvm-project/pull/84520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
Sirraide wrote:
> @Sirraide, I noticed the following build issue when new compiler with this
> change (bootstrap compiler) is being used to build one of the files for
> `clangd`:
>
> ```
> .../clang-tools-extra/clangd/unittests/FindTargetTests.cpp:430:29: error:
> passing no argument for the
zibi2 wrote:
@Sirraide, I noticed the following build issue when new compiler with this
change (bootstrap compiler) is being used to build one of the files for
`clangd`:
```
.../clang-tools-extra/clangd/unittests/FindTargetTests.cpp:430:29: error:
passing no argument for the '...' parameter
https://github.com/Sirraide closed
https://github.com/llvm/llvm-project/pull/84520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/84520
>From 502692869e3105bb2c55955bc4baff63b1475770 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 8 Mar 2024 18:15:07 +0100
Subject: [PATCH 1/3] [Clang] Update missing varargs arg extension warnings
---
clang/
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/84520
>From 502692869e3105bb2c55955bc4baff63b1475770 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 8 Mar 2024 18:15:07 +0100
Subject: [PATCH 1/3] [Clang] Update missing varargs arg extension warnings
---
clang/
@@ -993,11 +993,18 @@ MacroArgs *Preprocessor::ReadMacroCallArgumentList(Token
&MacroName,
// If the macro contains the comma pasting extension, the diagnostic
// is suppressed; we know we'll get another diagnostic later.
if (!MI->hasCommaPasting()) {
-
https://github.com/AaronBallman approved this pull request.
LGTM aside from a comment request
https://github.com/llvm/llvm-project/pull/84520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
@@ -993,11 +993,18 @@ MacroArgs *Preprocessor::ReadMacroCallArgumentList(Token
&MacroName,
// If the macro contains the comma pasting extension, the diagnostic
// is suppressed; we know we'll get another diagnostic later.
if (!MI->hasCommaPasting()) {
-
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/84520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/84520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
Just a nit here.
https://github.com/llvm/llvm-project/pull/84520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -993,11 +993,18 @@ MacroArgs *Preprocessor::ReadMacroCallArgumentList(Token
&MacroName,
// If the macro contains the comma pasting extension, the diagnostic
// is suppressed; we know we'll get another diagnostic later.
if (!MI->hasCommaPasting()) {
-
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/84520
>From 502692869e3105bb2c55955bc4baff63b1475770 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 8 Mar 2024 18:15:07 +0100
Subject: [PATCH 1/2] [Clang] Update missing varargs arg extension warnings
---
clang/
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Sirraide)
Changes
This updates a few warnings that were diagnosing no arguments for a `...`
variadic macro parameter as a GNU extension when it actually is a C++20/C23
extension now.
This fixes #84495.
---
Full diff: https://githu
https://github.com/Sirraide created
https://github.com/llvm/llvm-project/pull/84520
This updates a few warnings that were diagnosing no arguments for a `...`
variadic macro parameter as a GNU extension when it actually is a C++20/C23
extension now.
This fixes #84495.
>From 502692869e3105bb2c
18 matches
Mail list logo
