jhuber6 wrote:
> > This broke compilation with Xcode Clang 12 (roughly corresponding to
> > upstream Clang 10):
>
> It's not limited to that, I was seeing it too, it's breaking on 32-bit
> targets with older compilers that do not implicitly move between
> non-identical types. I've pushed the
hvdijk wrote:
> This broke compilation with Xcode Clang 12 (roughly corresponding to upstream
> Clang 10):
It's not limited to that, I was seeing it too, it's breaking on 32-bit targets
with older compilers that do not implicitly move between non-identical types.
I've pushed the obvious fix.
mstorsjo wrote:
This broke compilation with Xcode Clang 12 (roughly corresponding to upstream
Clang 10):
```
/Users/mstorsjo/nightly/llvm-mingw/src/llvm-project/clang/lib/Driver/Driver.
cpp:953:14: error: no viable conversion from returned value of type 'SmallVe
ctor<[...], 1>' to function retu
https://github.com/jsji edited https://github.com/llvm/llvm-project/pull/125556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -950,221 +930,264 @@ static bool addSYCLDefaultTriple(Compilation &C,
return true;
}
-void Driver::CreateOffloadingDeviceToolChains(Compilation &C,
- InputList &Inputs) {
-
- //
- // CUDA/HIP
- //
- // We need to generate a
jhuber6 wrote:
Should be fixed by
https://github.com/llvm/llvm-project/commit/dc87a14efb381d960c8fbf988221f31216d7f5fd.
The sentinel value used in this constant map was triggering UBSan.
https://github.com/llvm/llvm-project/pull/125556
___
cfe-commit
shiltian wrote:
I don't know which one. My PRs yesterday afternoon have a lot of crash in ADT
but after rebase a couple of hours later they were gone. I suppose that would
be the one.
https://github.com/llvm/llvm-project/pull/125556
___
cfe-commits m
jhuber6 wrote:
> Someone else messed up it. The commit has been reverted.
Can you link which one? That's some awfully convenient timing that it caused
failures on the offloading path at the same time I landed this.
https://github.com/llvm/llvm-project/pull/125556
__
shiltian wrote:
Someone else messed up it. The commit has been reverted.
https://github.com/llvm/llvm-project/pull/125556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
Yeah, seems like it's getting corrupt data in a dense map of offloading kinds?
Guess I'll need to do a sanitizer build.
https://github.com/llvm/llvm-project/pull/125556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
Meinersbur wrote:
Failures of the sinitizer builds look related to this
(https://lab.llvm.org/buildbot/#/builders/169/builds/13161):
```
0. Program arguments:
/home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/clang
-emit-llvm --cuda-device-only --offload=spirv32 -nocudal
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running
on `aix-ppc64` while building `clang` at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/64/builds/4943
Here is the relevant piece of the build lo
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-ppc64le-linux`
running on `ppc64le-sanitizer` while building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/72/builds/13357
Here is the relevant piece of the b
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while
building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/186/builds/10917
Here is the relev
@@ -109,65 +110,6 @@ using namespace clang::driver;
using namespace clang;
using namespace llvm::opt;
-static std::optional getOffloadTargetTriple(const Driver &D,
- const ArgList &Args)
{
- auto OffloadTargets = Args.
@@ -109,65 +110,6 @@ using namespace clang::driver;
using namespace clang;
using namespace llvm::opt;
-static std::optional getOffloadTargetTriple(const Driver &D,
- const ArgList &Args)
{
- auto OffloadTargets = Args.
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/125556
>From ffa2217d80f35c720b0b1860b2b9b71dd4099301 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 3 Feb 2025 12:46:27 -0600
Subject: [PATCH 1/3] [Clang] Introduce '--offload-targets=' to genericall
target t
@@ -458,6 +400,44 @@ phases::ID Driver::getFinalPhase(const DerivedArgList &DAL,
return FinalPhase;
}
+llvm::Expected>
+Driver::executeProgram(llvm::ArrayRef Args) const {
+ llvm::SmallString<64> OutputFile;
+ llvm::sys::fs::createTemporaryFile("driver-program", "txt", Out
@@ -950,221 +930,261 @@ static bool addSYCLDefaultTriple(Compilation &C,
return true;
}
-void Driver::CreateOffloadingDeviceToolChains(Compilation &C,
- InputList &Inputs) {
-
- //
- // CUDA/HIP
- //
- // We need to generate a
@@ -950,221 +930,261 @@ static bool addSYCLDefaultTriple(Compilation &C,
return true;
}
-void Driver::CreateOffloadingDeviceToolChains(Compilation &C,
- InputList &Inputs) {
-
- //
- // CUDA/HIP
- //
- // We need to generate a
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/125556
>From ffa2217d80f35c720b0b1860b2b9b71dd4099301 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 3 Feb 2025 12:46:27 -0600
Subject: [PATCH 1/2] [Clang] Introduce '--offload-targets=' to genericall
target t
@@ -14,14 +14,14 @@
// RUN: | FileCheck %s --check-prefix=NO-OUTPUT-ERROR
// RUN: not %clang -### --target=x86_64-unknown-linux-gnu -nogpulib
--offload-new-driver --offload-arch=native
--amdgpu-arch-tool=%t/amdgpu_arch_fail -x hip %s 2>&1 \
// RUN: | FileCheck %s --chec
@@ -3441,91 +3455,25 @@ class OffloadingActionBuilder final {
return true;
}
- ToolChains.push_back(
- AssociatedOffloadKind == Action::OFK_Cuda
- ? C.getSingleOffloadToolChain()
- : C.getSingleOffloadToolChain());
-
-
@@ -14,14 +14,14 @@
// RUN: | FileCheck %s --check-prefix=NO-OUTPUT-ERROR
// RUN: not %clang -### --target=x86_64-unknown-linux-gnu -nogpulib
--offload-new-driver --offload-arch=native
--amdgpu-arch-tool=%t/amdgpu_arch_fail -x hip %s 2>&1 \
// RUN: | FileCheck %s --chec
@@ -951,221 +931,262 @@ static bool addSYCLDefaultTriple(Compilation &C,
return true;
}
-void Driver::CreateOffloadingDeviceToolChains(Compilation &C,
- InputList &Inputs) {
-
- //
- // CUDA/HIP
- //
- // We need to generate a
@@ -3441,91 +3455,25 @@ class OffloadingActionBuilder final {
return true;
}
- ToolChains.push_back(
- AssociatedOffloadKind == Action::OFK_Cuda
- ? C.getSingleOffloadToolChain()
- : C.getSingleOffloadToolChain());
-
-
@@ -3441,91 +3455,25 @@ class OffloadingActionBuilder final {
return true;
}
- ToolChains.push_back(
- AssociatedOffloadKind == Action::OFK_Cuda
- ? C.getSingleOffloadToolChain()
- : C.getSingleOffloadToolChain());
-
-
https://github.com/Artem-B commented:
Drive-by style/syntax mostly review. LGTM overall, with a few nits.
https://github.com/llvm/llvm-project/pull/125556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
@@ -4,7 +4,7 @@
// RUN: --rocm-path=%S/Inputs/rocm \
// RUN: %s 2>&1 | FileCheck -check-prefix=NOPLUS %s
-// NOPLUS: error: invalid target ID 'gfx908xnack'
+// NOPLUS: error: unsupported HIP gpu architecture: gfx908xnack
Artem-B wrote:
"HIP compilation c
https://github.com/Artem-B edited
https://github.com/llvm/llvm-project/pull/125556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/125556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
31 matches
Mail list logo
