zyn0217 wrote:
It's still broken, and I haven’t figured out an approach to fix the regression.
I do recall that we were planning to wire up Sema and the constant evaluator,
so this patch might end up being completely superseded if that gets implemented.
https://github.com/llvm/llvm-project/pul
cor3ntin wrote:
@zyn0217 What is the status of that?
https://github.com/llvm/llvm-project/pull/95660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/95660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
Linux CI failed with an unrelated error.
```
TIMEOUT: lldb-api ::
functionalities/fork/concurrent_vfork/TestConcurrentVFork.py (87750 of 87750)
| TEST 'lldb-api ::
functionalities/fork/concurrent_vfork/TestConcurrentVFork.py' FAILED
``
zyn0217 wrote:
Thanks for the review! I will commit when CI turns green.
https://github.com/llvm/llvm-project/pull/95660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/95660
>From c288190c313d6990580048368c60a846919f98ae Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 15 Jun 2024 20:29:24 +0800
Subject: [PATCH 1/2] [Clang] Instantiate local constexpr functions eagerly
---
cl
https://github.com/mizvekov approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/95660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/95660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -18112,7 +18112,8 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc,
FunctionDecl *Func,
if (FirstInstantiation || TSK != TSK_ImplicitInstantiation ||
Func->isConstexpr()) {
- if (isa(Func->getDeclContext()) &&
+ if (!Func->isCon
EricWF wrote:
This looks good to me, but I'm not comfortable officially LGTMing it.
https://github.com/llvm/llvm-project/pull/95660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Younan Zhang (zyn0217)
Changes
We had a code path in `Sema::MarkFunctionReferenced()` that deferred local
lambda instantiation even for constexprs. This resulted in any calls to them
referring to function decls that lack bodies and hence
https://github.com/zyn0217 ready_for_review
https://github.com/llvm/llvm-project/pull/95660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/95660
We had a code path in `Sema::MarkFunctionReferenced()` that deferred local
lambda instantiation even for constexprs. This resulted in any calls to them
referring to function decls that lack bodies and hence fail
13 matches
Mail list logo
