[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-18 Thread via cfe-commits
dyung wrote: > > I'm seeing our internal downstream builder hit the exact same error in this > > test, but that is building a Windows hosted compiler targeting Windows. > > Looking at our runs, it seems to have started appearing after your change > > [479ffe8](https://github.com/llvm/llvm-proj

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-11 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I'm seeing our internal downstream builder hit the exact same error in this > test, but that is building a Windows hosted compiler targeting Windows. > Looking at our runs, it seems to have started appearing after your change > [479ffe8](https://github.com/llvm/llvm-project/co

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-11 Thread via cfe-commits
dyung wrote: > > And just now another failure: > > https://lab.llvm.org/buildbot/#/builders/190/builds/14342 > > Honestly, I don't know. I'd say that it's because we don't support offloading > on Darwin, but the triple is supposed to be x64. I could probably just set > the test to unsupported

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-09 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > And just now another failure: > https://lab.llvm.org/buildbot/#/builders/190/builds/14342 Honestly, I don't know. I'd say that it's because we don't support offloading on Darwin, but the triple is supposed to be x64. I could probably just set the test to unsupported for darwi

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-08 Thread via cfe-commits
dyung wrote: And just now another failure: https://lab.llvm.org/buildbot/#/builders/190/builds/14342 https://github.com/llvm/llvm-project/pull/126248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-08 Thread via cfe-commits
dyung wrote: @jhuber6 I've seen 2 seemingly random failures of the offload-Xarch.c test on my mac buildbots lately. Any idea why this might be happening? https://lab.llvm.org/buildbot/#/builders/190/builds/14302 https://lab.llvm.org/buildbot/#/builders/23/builds/7414 The test generally seems t

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/126248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Joseph Huber via cfe-commits
@@ -9203,7 +9203,9 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, ArgStringList CompilerArgs; ArgStringList LinkerArgs; for (Arg *A : C.getArgsForToolChain(TC, /*BoundArch=*/"", Kind)) { -if (ShouldForward(CompilerOptions, A)

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Nick Sarnie via cfe-commits
@@ -9203,7 +9203,9 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, ArgStringList CompilerArgs; ArgStringList LinkerArgs; for (Arg *A : C.getArgsForToolChain(TC, /*BoundArch=*/"", Kind)) { -if (ShouldForward(CompilerOptions, A)

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex approved this pull request. https://github.com/llvm/llvm-project/pull/126248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Nick Sarnie via cfe-commits
@@ -9203,7 +9203,9 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, ArgStringList CompilerArgs; ArgStringList LinkerArgs; for (Arg *A : C.getArgsForToolChain(TC, /*BoundArch=*/"", Kind)) { -if (ShouldForward(CompilerOptions, A)

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/126248 >From 10727e968d69bc3f0848a1cbbd0f3e5012b09d5f Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 7 Feb 2025 08:31:08 -0600 Subject: [PATCH 1/2] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains Summary

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: This patch handles the use of `-Xarch_ -Wl,foo` to send an argument to the linker for the embedded offloading jobs in the linker wrapper. This makes it equivalent to `-Xoffload-linker foo`. --

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes Summary: This patch handles the use of `-Xarch_ -Wl,foo` to send an argument to the linker for the embedded offloading jobs in the linker wrapper. This makes it equivalent to `-Xoffload-linker foo

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/126248 Summary: This patch handles the use of `-Xarch_ -Wl,foo` to send an argument to the linker for the embedded offloading jobs in the linker wrapper. This makes it equivalent to `-Xoffload-linker foo`. >From 10727