github-actions[bot] wrote:
@maxmosk Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build,
https://github.com/Sirraide closed
https://github.com/llvm/llvm-project/pull/90441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide approved this pull request.
https://github.com/llvm/llvm-project/pull/90441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/maxmosk updated
https://github.com/llvm/llvm-project/pull/90441
>From 723b4be4076ff9723663f529153b6a0acde27201 Mon Sep 17 00:00:00 2001
From: Maxim Moskalets
Date: Tue, 30 Apr 2024 12:51:43 +0300
Subject: [PATCH] [Clang][Docs] Synchronize the LibTooling example
Synchronize t
Sirraide wrote:
Right, what `clang-format` is suggesting here is a bit bizzare; please reformat
the comment manually so every line fits within the 80 column limit.
https://github.com/llvm/llvm-project/pull/90441
___
cfe-commits mailing list
cfe-commit
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 10aab63c9cb49d3ddfbe2cf8992de433efeef6f1
a09f0c836a4e8296ccae3c51889f90dea38c304c --
https://github.com/Sirraide approved this pull request.
LGTM seeing as this matches what’s already in the documentation.
https://github.com/llvm/llvm-project/pull/90441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
maxmosk wrote:
@Sirraide updated with header doc fix, please review
https://github.com/llvm/llvm-project/pull/90441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/maxmosk updated
https://github.com/llvm/llvm-project/pull/90441
>From a09f0c836a4e8296ccae3c51889f90dea38c304c Mon Sep 17 00:00:00 2001
From: Maxim Moskalets
Date: Tue, 30 Apr 2024 12:51:43 +0300
Subject: [PATCH] [Clang][Docs] Synchronize the LibTooling example
Synchronize t
Sirraide wrote:
> This PR wasn't approved and doc is still not fixed :( What to do with this PR?
It somehow just went unnoticed all this time, unfortunately. I’ll approve the
other pr since it seems to do the same thing that we’re also doing somewhere
else in our documentation, and it’s pretty
maxmosk wrote:
> I also just noticed that there already is a pr for this: #70427.
This PR wasn't approved and doc is still not fixed :(
What to do with this PR?
https://github.com/llvm/llvm-project/pull/90441
___
cfe-commits mailing list
cfe-commits@l
Sirraide wrote:
I also just noticed that there already is a pr for this: #70427.
https://github.com/llvm/llvm-project/pull/90441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -56,9 +56,9 @@ namespace tooling {
/// ...
///
/// int main(int argc, const char **argv) {
-/// CommonOptionsParser OptionsParser(argc, argv, MyToolCategory);
-/// ClangTool Tool(OptionsParser.getCompilations(),
-/// OptionsParser.getSourcePathList());
+
@@ -71,9 +71,9 @@ and automatic location of the compilation database using
source files paths.
int main(int argc, const char **argv) {
// CommonOptionsParser constructor will parse arguments and create a
// CompilationDatabase. In case of error it will terminate the
@@ -133,9 +133,9 @@ version of this example tool is also checked into the clang
tree at
static cl::extrahelp MoreHelp("\nMore help text...\n");
int main(int argc, const char **argv) {
-CommonOptionsParser OptionsParser(argc, argv, MyToolCategory);
-ClangTool Tool(
@@ -71,9 +71,9 @@ and automatic location of the compilation database using
source files paths.
int main(int argc, const char **argv) {
// CommonOptionsParser constructor will parse arguments and create a
// CompilationDatabase. In case of error it will terminate the
@@ -71,9 +71,9 @@ and automatic location of the compilation database using
source files paths.
int main(int argc, const char **argv) {
// CommonOptionsParser constructor will parse arguments and create a
// CompilationDatabase. In case of error it will terminate the
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/90441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide requested changes to this pull request.
Thanks for improving our documentation!
There’s some error handling missing here. The `CommonOptionsParser` constructor
would previously just exit, but that is no longer the case here, so we actually
need to handle errors now.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Maxim Moskalets (maxmosk)
Changes
Replace CommonOptionsParser ctor by factory method ::create.
Found on page https://clang.llvm.org/docs/LibTooling.html
---
Full diff: https://github.com/llvm/llvm-project/pull/90441.diff
2 Files Affecte
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/maxmosk created
https://github.com/llvm/llvm-project/pull/90441
Replace CommonOptionsParser ctor by factory method ::create.
Found on page https://clang.llvm.org/docs/LibTooling.html
>From ed05f896b39f4bd6feb6fa01375d3971064b15fb Mon Sep 17 00:00:00 2001
From: Maxim Moskalet
22 matches
Mail list logo
