https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/99716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/99716
>From 02012a704c4ad0c666d38bf2b2a7bf74c7f3b2c1 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Fri, 19 Jul 2024 17:33:08 -0500
Subject: [PATCH] [Clang] Fix C library wrappers for offloading
Summary:
This block
jhuber6 wrote:
> Yeah, rewriting the function signature is gonna be quite a hassle. LG for now.
>
> If we change the function signature, does it make easier to set default
> argument?
It'll be similar code, but it would allow us to use the same helpers that the
other targets use.
https://git
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/99716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shiltian approved this pull request.
Yeah, rewriting the function signature is gonna be quite a hassle. LG for now.
If we change the function signature, does it make easier to set default
argument?
https://github.com/llvm/llvm-project/pull/99716
_
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Joseph Huber (jhuber6)
Changes
Summary:
This block of code wraps around the standard C library includes.
However, the order C library includes are presented is actually
important. If they are visible before the `libc++` headers then it will
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/99716
Summary:
This block of code wraps around the standard C library includes.
However, the order C library includes are presented is actually
important. If they are visible before the `libc++` headers then it will
cau
