[clang] [Clang] - Add libclangSerialization to clang driver unittests (PR #109329)

2024-09-19 Thread Pranav Bhandarkar via cfe-commits
bhandarkar-pranav wrote: > I just merged my revert PR #109340 I'll investigate further on the cause for > the warning that shows up in the build bots causing the test failure Sounds good. As you can see, my fix is unrelated to this issue that you are seeing which seems to be real issue worth i

[clang] [Clang] - Add libclangSerialization to clang driver unittests (PR #109329)

2024-09-19 Thread via cfe-commits
Prabhuk wrote: I just merged my revert PR https://github.com/llvm/llvm-project/pull/109340 I'll investigate further on the cause for the warning that shows up in the build bots causing the test failure https://github.com/llvm/llvm-project/pull/109329 ___

[clang] [Clang] - Add libclangSerialization to clang driver unittests (PR #109329)

2024-09-19 Thread via cfe-commits
Prabhuk wrote: It seems like we are still seeing failures: https://lab.llvm.org/buildbot/#/builders/190/builds/6112 https://github.com/llvm/llvm-project/pull/109329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [Clang] - Add libclangSerialization to clang driver unittests (PR #109329)

2024-09-19 Thread via cfe-commits
Prabhuk wrote: I am holding off of on my revert PR to see if the current build bot with this patch goes through successfully! Thanks again Pranav. https://github.com/llvm/llvm-project/pull/109329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] - Add libclangSerialization to clang driver unittests (PR #109329)

2024-09-19 Thread via cfe-commits
Prabhuk wrote: Thank you Pranav! This looks like a reasonable fix to me. I just created a revert PR though since I cannot test this right away locally. https://github.com/llvm/llvm-project/pull/109329 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [Clang] - Add libclangSerialization to clang driver unittests (PR #109329)

2024-09-19 Thread Pranav Bhandarkar via cfe-commits
https://github.com/bhandarkar-pranav closed https://github.com/llvm/llvm-project/pull/109329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] - Add libclangSerialization to clang driver unittests (PR #109329)

2024-09-19 Thread Pranav Bhandarkar via cfe-commits
https://github.com/bhandarkar-pranav edited https://github.com/llvm/llvm-project/pull/109329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] - Add libclangSerialization to clang driver unittests (PR #109329)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Pranav Bhandarkar (bhandarkar-pranav) Changes This PR is a fix for issue [#109328](https://github.com/llvm/llvm-project/issues/109328). libclangSerializaton.so is needed for building clang driver unittests

[clang] [Clang] - Add libclangSerialization to clang driver unittests (PR #109329)

2024-09-19 Thread Pranav Bhandarkar via cfe-commits
https://github.com/bhandarkar-pranav created https://github.com/llvm/llvm-project/pull/109329 This PR is a fix for issue [#109328](https://github.com/llvm/llvm-project/issues/109328). libclangSerializaton.so is needed for building clang driver unittests after https://github.com/llvm/llvm-proje