Sirraide wrote:
> As I mentioned, I’m going to make a follow-up pr to this soon so we can
> discuss what to do with `__attribute__((assume))`/`[[clang::assume]]`.
Just opened a pr for this: #84934
https://github.com/llvm/llvm-project/pull/84582
___
Sirraide wrote:
As I mentioned, I’m going to make a follow-up pr to this soon so we can discuss
what to do with `__attribute__((assume))`/`[[clang::assume]]`.
https://github.com/llvm/llvm-project/pull/84582
___
cfe-commits mailing list
cfe-commits@lis
https://github.com/Sirraide closed
https://github.com/llvm/llvm-project/pull/84582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/84582
>From d436f7fefb967f050220a8ede6d05c8e26f363b3 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 8 Mar 2024 23:54:14 +0100
Subject: [PATCH 1/4] [Clang] [Parser] Support [[omp::assume]]
---
clang/include/clang
@@ -192,6 +192,8 @@ Removed Compiler Flags
Attribute Changes in Clang
--
+- Added support for the `[[omp::assume]]` attribute.
AaronBallman wrote:
I'd recommend adding a section to clang's release notes for OpenMP in that case.
https:
@@ -192,6 +192,8 @@ Removed Compiler Flags
Attribute Changes in Clang
--
+- Added support for the `[[omp::assume]]` attribute.
Sirraide wrote:
> This should probably go under an OpenMP-specific section as it relates more
> to OpenMP t
@@ -192,6 +192,8 @@ Removed Compiler Flags
Attribute Changes in Clang
--
+- Added support for the `[[omp::assume]]` attribute.
AaronBallman wrote:
This should probably go under an OpenMP-specific section as it relates more to
OpenMP t
https://github.com/AaronBallman approved this pull request.
The precommit CI failure is not an actual issue, so LGTM with a suggestion for
the release note. Thank you for this!
https://github.com/llvm/llvm-project/pull/84582
___
cfe-commits mailing li
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/84582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/84582
>From d436f7fefb967f050220a8ede6d05c8e26f363b3 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 8 Mar 2024 23:54:14 +0100
Subject: [PATCH 1/3] [Clang] [Parser] Support [[omp::assume]]
---
clang/include/clang
@@ -12,3 +14,18 @@ void f9(void) __attribute__((assume("omp_no_openmp",
"omp_no_openmp"))); // expe
int g1 __attribute__((assume(0))); // expected-error {{expected string literal
as argument of 'assume' attribute}}
int g2 __attribute__((assume("omp_no_openmp"))); // expected
@@ -12,3 +14,18 @@ void f9(void) __attribute__((assume("omp_no_openmp",
"omp_no_openmp"))); // expe
int g1 __attribute__((assume(0))); // expected-error {{expected string literal
as argument of 'assume' attribute}}
int g2 __attribute__((assume("omp_no_openmp"))); // expected
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/84582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/84582
>From d436f7fefb967f050220a8ede6d05c8e26f363b3 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 8 Mar 2024 23:54:14 +0100
Subject: [PATCH 1/2] [Clang] [Parser] Support [[omp::assume]]
---
clang/include/clang
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/84582
>From d436f7fefb967f050220a8ede6d05c8e26f363b3 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 8 Mar 2024 23:54:14 +0100
Subject: [PATCH 1/2] [Clang] [Parser] Support [[omp::assume]]
---
clang/include/clang
Sirraide wrote:
Ok yeah, good, looks like that’s the right attribute to map `[[omp::assume]]`
to.
https://github.com/llvm/llvm-project/pull/84582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
alexey-bataev wrote:
> One more thing: this is just a different spelling for what was previously
> already exposed as `__attribute__((assume))`; I’m not sure if/how familiar
> you are with that one, but I hope its semantics align with what
> `[[omp::assume]]` is supposed to do. I’m asking beca
Sirraide wrote:
> Currently only for C++11 and higher
Ok, good; that’ll make this easier.
> https://www.openmp.org/wp-content/uploads/OpenMP-API-Specification-5-2.pdf,
> pages 49-50
Thanks. At a glance, it looks like there are more things that also still need
to be implemented in the fronten
alexey-bataev wrote:
> @alexey-bataev I have a few more questions about `[[omp::assume]]`:
>
> - Is this supported in C? Because the `[[]]` spelling is only officially
> available in C23 and later (we *do* support it in earlier language modes, but
> users will get a warning if `-pedantic` is p
alexey-bataev wrote:
> @alexey-bataev I have a few more questions about `[[omp::assume]]`:
>
> - Is this supported in C? Because the `[[]]` spelling is only officially
> available in C23 and later (we *do* support it in earlier language modes, but
> users will get a warning if `-pedantic` is p
Sirraide wrote:
One more thing: this is just a different spelling for what was previously
already exposed as `__attribute__((assume))`; I’m not sure if/how familiar you
are with that one, but I hope its semantics align with what `[[omp::assume]]`
is supposed to do. I’m asking because I’m not t
Sirraide wrote:
@alexey-bataev I have a few more questions about `[[omp::assume]]`:
- Is this supported in C? Because the `[[]]` spelling is only officially
available in C23 and later (we *do* support it in earlier language modes, but
users will get a warning if `-pedantic` is passed)
- Is ther
llvmbot wrote:
@llvm/pr-subscribers-openmp
Author: None (Sirraide)
Changes
This pr implements the `[[omp::assume]]` spelling for the
`__attribute__((assume))` attribute. It does not change anything about how that
attribute is handled by the rest of Clang.
This pr is only *not* meant for
https://github.com/Sirraide created
https://github.com/llvm/llvm-project/pull/84582
This pr implements the `[[omp::assume]]` spelling for the
`__attribute__((assume))` attribute. It does not change anything about how that
attribute is handled by the rest of Clang.
This pr is only *not* meant
24 matches
Mail list logo
