[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-11-05 Thread via cfe-commits
Sirraide wrote: CI failure seems unrlated considering that the DRAV is quite literally unused at the moment https://github.com/llvm/llvm-project/pull/110040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-11-05 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-hwasan` running on `sanitizer-buildbot11` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/3351 Here is the rel

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-11-05 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/110040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-11-05 Thread via cfe-commits
Sirraide wrote: Thanks for the reviews! The next step for me will be to start migrating the AST visitor tests (or rather, take all the changes that I have on the other branch and make a new pr). https://github.com/llvm/llvm-project/pull/110040 ___ cf

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-11-05 Thread Nikita Popov via cfe-commits
nikic wrote: > I think these are a net positive change; @nikic are you comfortable with the > performance numbers? I feel like the changes come awfully close to falling > out in the noise aside from the positive improvements with building Clang, > but you look at compile time performance numbe

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-11-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. I think these are a net positive change; @nikic are you comfortable with the performance numbers? I feel like the changes come awfully close to falling out in the noise aside from the positive improvements with building Clang, but you

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-11-04 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,268 @@ +//===--- DynamicRecursiveASTVisitor.h - Virtual AST Visitor -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-11-04 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,268 @@ +//===--- DynamicRecursiveASTVisitor.h - Virtual AST Visitor -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-11-04 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! Do you have some performance numbers you can share which sells us on the changes? https://github.com/llvm/llvm-project/pull/110040 ___ cfe-commits mailing list cfe-commits@lists

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-11-04 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,452 @@ +//=== DynamicRecursiveASTVisitor.cpp - Dynamic AST Visitor Implementation -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-11-04 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/110040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-22 Thread via cfe-commits
@@ -0,0 +1,268 @@ +//===--- DynamicRecursiveASTVisitor.h - Virtual AST Visitor -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-22 Thread via cfe-commits
@@ -0,0 +1,268 @@ +//===--- DynamicRecursiveASTVisitor.h - Virtual AST Visitor -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-22 Thread via cfe-commits
@@ -0,0 +1,268 @@ +//===--- DynamicRecursiveASTVisitor.h - Virtual AST Visitor -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-22 Thread via cfe-commits
@@ -0,0 +1,268 @@ +//===--- DynamicRecursiveASTVisitor.h - Virtual AST Visitor -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-22 Thread via cfe-commits
@@ -0,0 +1,452 @@ +//=== DynamicRecursiveASTVisitor.cpp - Dynamic AST Visitor Implementation -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-22 Thread via cfe-commits
@@ -0,0 +1,268 @@ +//===--- DynamicRecursiveASTVisitor.h - Virtual AST Visitor -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-22 Thread via cfe-commits
@@ -0,0 +1,452 @@ +//=== DynamicRecursiveASTVisitor.cpp - Dynamic AST Visitor Implementation -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-22 Thread via cfe-commits
@@ -0,0 +1,268 @@ +//===--- DynamicRecursiveASTVisitor.h - Virtual AST Visitor -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-22 Thread via cfe-commits
Sirraide wrote: @AaronBallman ping https://github.com/llvm/llvm-project/pull/110040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-08 Thread via cfe-commits
Sirraide wrote: ping https://github.com/llvm/llvm-project/pull/110040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-01 Thread via cfe-commits
Sirraide wrote: ping https://github.com/llvm/llvm-project/pull/110040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-09-25 Thread via cfe-commits
@@ -0,0 +1,452 @@ +//=== DynamicRecursiveASTVisitor.cpp - Dynamic AST Visitor Implementation -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-09-25 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/110040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-09-25 Thread via cfe-commits
@@ -0,0 +1,452 @@ +//=== DynamicRecursiveASTVisitor.cpp - Dynamic AST Visitor Implementation -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-09-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes Following the discussion on #105195, we decided to split this into multiple prs. This one is just the DRAV implementation. Tests for it will be added in a separate pr because testing this involves just rewriting

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-09-25 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/110040 Following the discussion on #105195, we decided to split this into multiple prs. This one is just the DRAV implementation. Tests for it will be added in a separate pr because testing this involves just rewri