https://github.com/sjoerdmeijer closed
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sjoerdmeijer wrote:
Thanks for your reviews! I will make those changes before merging this.
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
https://github.com/andykaylor approved this pull request.
I'm happy with the latest changes, so after the "standards" wording changes
Erich and Aaron requested, this should be good to go.
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commit
https://github.com/AaronBallman approved this pull request.
Generally LGTM, with a nit about C/C++
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1681,19 +1681,27 @@ for more details.
permitted to produce more precise results than performing the same
operations separately.
- The C standard permits intermediate floating-point results within an
+ The C/C++ standard permits intermediate floating-point results
@@ -1681,19 +1681,27 @@ for more details.
permitted to produce more precise results than performing the same
operations separately.
- The C standard permits intermediate floating-point results within an
+ The C/C++ standard permits intermediate floating-point results
https://github.com/erichkeane approved this pull request.
Happy when @andykaylor is.
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1681,19 +1681,25 @@ for more details.
permitted to produce more precise results than performing the same
operations separately.
- The C standard permits intermediate floating-point results within an
+ The C/C++ standard permits intermediate floating-point results
@@ -1681,19 +1681,25 @@ for more details.
permitted to produce more precise results than performing the same
operations separately.
- The C standard permits intermediate floating-point results within an
+ The C/C++ standard permits intermediate floating-point results
https://github.com/sjoerdmeijer commented:
Thanks for the review. I have addressed the comments, I think.
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/sjoerdmeijer edited
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sjoerdmeijer updated
https://github.com/llvm/llvm-project/pull/127621
>From d7483fc138c0834fbed84bb43521ce8caed84528 Mon Sep 17 00:00:00 2001
From: Sjoerd Meijer
Date: Tue, 18 Feb 2025 03:37:08 -0800
Subject: [PATCH] [Clang][doc] -ffp-contract options and standard compliance
https://github.com/andykaylor commented:
This is an improvement. I have a few minor comments.
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/andykaylor edited
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1681,19 +1681,25 @@ for more details.
permitted to produce more precise results than performing the same
operations separately.
- The C standard permits intermediate floating-point results within an
+ The C/C++ standard permits intermediate floating-point results
@@ -1681,19 +1681,25 @@ for more details.
permitted to produce more precise results than performing the same
operations separately.
- The C standard permits intermediate floating-point results within an
+ The C/C++ standard permits intermediate floating-point results
@@ -1681,19 +1681,25 @@ for more details.
permitted to produce more precise results than performing the same
operations separately.
- The C standard permits intermediate floating-point results within an
+ The C/C++ standard permits intermediate floating-point results
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sjoerd Meijer (sjoerdmeijer)
Changes
We had an internal discussion about -ffp-contract, how it compared to GCC which
defaults to fast, and standard compliance. Looking at our docs, I think most
information is there, but also thought it co
https://github.com/sjoerdmeijer created
https://github.com/llvm/llvm-project/pull/127621
We had an internal discussion about -ffp-contract, how it compared to GCC which
defaults to fast, and standard compliance. Looking at our docs, I think most
information is there, but also thought it could
21 matches
Mail list logo