https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/80899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/80899
>From 671a0b01f0131b3d1dedfd3c9f74dcbe29a615b5 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 6 Feb 2024 14:22:37 -0500
Subject: [PATCH] [Clang][Sema] Implement proposed resolution for CWG2847
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/80899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll approved this pull request.
DR testing looks good now. Thank you for bearing with me!
I tried to give this a proper in-depth review, but the only corner case that
comes to my mind is conversion functions. Feel free to dismiss it if you don't
think it's relevant or int
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/80899
>From f9079ac4098b2debf3df4ebee3e5f4f0c2b1e6a2 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 6 Feb 2024 14:22:37 -0500
Subject: [PATCH 1/2] [Clang][Sema] Implement proposed resolution for CWG28
sdkrystian wrote:
Whoops... changed it to `202002L` :)
https://github.com/llvm/llvm-project/pull/80899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/80899
>From f9079ac4098b2debf3df4ebee3e5f4f0c2b1e6a2 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 6 Feb 2024 14:22:37 -0500
Subject: [PATCH 1/2] [Clang][Sema] Implement proposed resolution for CWG28
@@ -0,0 +1,41 @@
+// RUN: %clang_cc1 -std=c++20 -verify=expected %s
+
+namespace dr2847 { // dr2847: 19
+
Endilll wrote:
`#if __cplusplus >= 202302L` skips over C++20, which doesn't seem intentional
given the previous iteration of this PR I reviewed. I also put
https://github.com/Endilll commented:
Much better, thank you. Couple of small changes, and DR test should be good to
go.
https://github.com/llvm/llvm-project/pull/80899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/80899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
@Endilll I applied your suggested changes... how does it look?
https://github.com/llvm/llvm-project/pull/80899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/80899
>From f9079ac4098b2debf3df4ebee3e5f4f0c2b1e6a2 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 6 Feb 2024 14:22:37 -0500
Subject: [PATCH 1/2] [Clang][Sema] Implement proposed resolution for CWG28
@@ -0,0 +1,41 @@
+// RUN: %clang_cc1 -std=c++20 -verify=expected %s
Endilll wrote:
Can you copy RUN lines from `dr26xx.cpp`, adding verify prefixed you need in
your test (`since-cxx20`)?
https://github.com/llvm/llvm-project/pull/80899
__
@@ -0,0 +1,41 @@
+// RUN: %clang_cc1 -std=c++20 -verify=expected %s
+
+namespace dr2847 { // dr2847: 19
+
Endilll wrote:
As this test requires C++20, it should be wrapped in `#if __cplusplus`.
https://github.com/llvm/llvm-project/pull/80899
@@ -0,0 +1,41 @@
+// RUN: %clang_cc1 -std=c++20 -verify=expected %s
+
+namespace dr2847 { // dr2847: 19
+
+template
+void i();
+
+struct A {
+ template
+ void f() requires true;
+
+ template<>
+ void f() requires true; // expected-error {{explicit specialization
cannot have a
https://github.com/Endilll requested changes to this pull request.
Since you're creating a new file in C++ DR test suite, I left several comments
to guide you towards bringing this new file up to speed with the rest of the
suite.
https://github.com/llvm/llvm-project/pull/80899
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/80899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
Per the approved resolution for
[CWG2847](https://cplusplus.github.io/CWG/issues/2847.html), [temp.expl.spec]
p8 will state:
> An explicit specialization shall not have a trailing _requires-clause_
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/80899
Per the approved resolution for
[CWG2847](https://cplusplus.github.io/CWG/issues/2847.html), [temp.expl.spec]
p8 will state:
> An explicit specialization shall not have a trailing _requires-clause_ unless
>
19 matches
Mail list logo
