github-actions[bot] wrote:
@awson Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build, y
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/96464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
awson wrote:
> If you have approvals you don't have to wait for other reviewers unless they
> have made a comment that required a change and you them to confirm the fix or
> they explicitly blocked the review.
I believe I have no write access to the repo.
Could you, please, merge this?
@cor3
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464
>From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001
From: awson
Date: Mon, 24 Jun 2024 10:34:51 +0300
Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early.
---
clang/lib/Se
https://github.com/shafik approved this pull request.
If you have approvals you don't have to wait for other reviewers unless they
have made a comment that required a change and you them to confirm the fix or
they explicitly blocked the review.
https://github.com/llvm/llvm-project/pull/96464
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464
>From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001
From: awson
Date: Mon, 24 Jun 2024 10:34:51 +0300
Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early.
---
clang/lib/Se
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464
>From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001
From: awson
Date: Mon, 24 Jun 2024 10:34:51 +0300
Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early.
---
clang/lib/Se
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464
>From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001
From: awson
Date: Mon, 24 Jun 2024 10:34:51 +0300
Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early.
---
clang/lib/Se
awson wrote:
@shafik ?
https://github.com/llvm/llvm-project/pull/96464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464
>From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001
From: awson
Date: Mon, 24 Jun 2024 10:34:51 +0300
Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early.
---
clang/lib/Se
https://github.com/erichkeane approved this pull request.
LGTM, feel free to merge.
https://github.com/llvm/llvm-project/pull/96464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464
>From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001
From: awson
Date: Mon, 24 Jun 2024 10:34:51 +0300
Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early.
---
clang/lib/Se
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/96464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464
>From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001
From: awson
Date: Mon, 24 Jun 2024 10:34:51 +0300
Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early.
---
clang/lib/Se
erichkeane wrote:
> > It seems reasonable to me, but I want @cor3ntin to review this, he's the
> > one who got his foot stuck in array bounds for a while :D
> > However, this patch needs a few changes:
> > 1- A better patch title, perhaps improved commit message 2- Release note
>
> 1. Parti
awson wrote:
> It seems reasonable to me, but I want @cor3ntin to review this, he's the one
> who got his foot stuck in array bounds for a while :D
>
> However, this patch needs a few changes:
>
> 1- A better patch title, perhaps improved commit message 2- Release note
1. Partially (patch tit
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464
>From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001
From: awson
Date: Mon, 24 Jun 2024 10:34:51 +0300
Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early.
---
clang/lib/Se
https://github.com/awson edited https://github.com/llvm/llvm-project/pull/96464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
18 matches
Mail list logo
