[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

https://github.com/hstk30-hw closed https://github.com/llvm/llvm-project/pull/76007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

https://github.com/aaronpuchert approved this pull request. https://github.com/llvm/llvm-project/pull/76007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/76007 >From 8e00f9313edb18afd087433e69d9469bec4c7b19 Mon Sep 17 00:00:00 2001 From: hstk30-hw Date: Wed, 20 Dec 2023 12:26:15 +0800 Subject: [PATCH] [Clang][Sema] Fix Wswitch-default bad warning in template [#73077]

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 92f17714e8410986ebfd7b3ebbc48529d6449253 d6c5cfe089b283b35660a48c5d056f44c65e2be4 --

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/76007 >From d6c5cfe089b283b35660a48c5d056f44c65e2be4 Mon Sep 17 00:00:00 2001 From: hstk30-hw Date: Wed, 20 Dec 2023 12:26:15 +0800 Subject: [PATCH] [Clang][Sema] Fix Wswitch-default bad warning in template [#73077]

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

https://github.com/dongjianqiang2 approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/76007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

shafik wrote: > For now I guess this is Ok, although I think the better fix would be to > diagnose missing or duplicate `default` labels even in the dependent case. > Because `default` labels themselves are never dependent. We should probably add a FIXME for this. https://github.com/llvm/llvm

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

https://github.com/aaronpuchert approved this pull request. For now I guess this is Ok, although I think the better fix would be to diagnose missing or duplicate `default` labels even in the dependent case. Because `default` labels themselves are never dependent. https://github.com/llvm/llvm-p

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

https://github.com/cor3ntin approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/76007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/76007 >From 2991e9b990702b22f67b1d7a146605b1388cec87 Mon Sep 17 00:00:00 2001 From: hstk30-hw Date: Wed, 20 Dec 2023 12:26:15 +0800 Subject: [PATCH] [Clang][Sema] Fix Wswitch-default bad warning in template [#73077]

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

dongjianqiang2 wrote: thanks for correcting this. https://github.com/llvm/llvm-project/pull/76007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/76007 >From 7b8c1c758c77550536b9d16027b2e51090e365be Mon Sep 17 00:00:00 2001 From: hstk-hw Date: Wed, 20 Dec 2023 12:26:15 +0800 Subject: [PATCH]in templates. This PR will address that. --- clang/lib/Sema/

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

https://github.com/hstk30-hw edited https://github.com/llvm/llvm-project/pull/76007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

@@ -0,0 +1,27 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 -Wswitch-default %s shafik wrote: I think we can add these test to `clang/test/Sema/switch-default.c` https://github.com/llvm/llvm-project/pull/76007 __

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

shafik wrote: Can you add more details to you summary "https://github.com/llvm/llvm-project/pull/73077 added -Wswitch-default diagnostic but it produced false positives in templates. This PR will address that issue" https://github.com/llvm/llvm-project/pull/76007 ___

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (hstk30-hw) Changes Fix https://github.com/llvm/llvm-project/issues/75943 --- Full diff: https://github.com/llvm/llvm-project/pull/76007.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaStmt.cpp (+1-3) - (added) clang/test/S

[clang] [Clang][Sema] Fix Wswitch-default bad warning in template (PR #76007)

https://github.com/hstk30-hw created https://github.com/llvm/llvm-project/pull/76007 Fix https://github.com/llvm/llvm-project/issues/75943 >From c3d5ac42726c49fd7036972042eb70d3e5dc01a6 Mon Sep 17 00:00:00 2001 From: hstk-hw Date: Wed, 20 Dec 2023 12:26:15 +0800 Subject: [PATCH] fix: fix Wswit