[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

2023-09-08 Thread Nathan Chancellor via cfe-commits
https://github.com/nathanchance closed https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

2023-09-07 Thread Lu Weining via cfe-commits
https://github.com/SixWeining approved this pull request. I have checked that glibc/sysdeps/loongarch/machine-gmon.h defines `_mcount`. https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

2023-09-07 Thread Lu Weining via cfe-commits
SixWeining wrote: > also cc @SixWeining (BTW we want to have a GitHub team set up for > notifications and assignments apparently) There is one: https://github.com/orgs/llvm/teams/pr-subscribers-loongarch I will invite you to join this team and others interested in could also request to join.

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

2023-09-07 Thread WÁNG Xuěruì via cfe-commits
xen0n wrote: also cc @SixWeining (BTW we want to have a GitHub team set up for notifications and assignments apparently) It's 4 am here and I'd take a look after getting some sleep, to ensure review quality ;-) https://github.com/llvm/llvm-project/pull/65657 __

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

2023-09-07 Thread Nathan Chancellor via cfe-commits
nathanchance wrote: cc @xen0n https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

2023-09-07 Thread Nathan Chancellor via cfe-commits
https://github.com/nathanchance review_requested https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

2023-09-07 Thread Nathan Chancellor via cfe-commits
https://github.com/nathanchance review_requested https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

2023-09-07 Thread Nathan Chancellor via cfe-commits
https://github.com/nathanchance created https://github.com/llvm/llvm-project/pull/65657: When building the LoongArch Linux kernel without `CONFIG_DYNAMIC_FTRACE`, the build fails to link because the mcount symbol is `mcount`, not `_mcount` like GCC generates and the kernel expects: ``` ld.lld

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

2023-09-07 Thread Nathan Chancellor via cfe-commits
https://github.com/nathanchance review_requested https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits