https://github.com/yxsamliu closed
https://github.com/llvm/llvm-project/pull/87651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B approved this pull request.
https://github.com/llvm/llvm-project/pull/87651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yxsamliu wrote:
ping
It passes our internal Windows CI.
https://github.com/llvm/llvm-project/pull/87651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yxsamliu wrote:
> In general, having different C++ ABIs between the host and device seems like
> an ongoing source of tension and bugs.
I agree. However completely switching to Microsoft ABI on device side does not
work with existing device libraries since they assume Itanium mangling.
Theref
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/87651
>From fcebb8226599160fd6e6e42356f78d0b1d4367d4 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Thu, 4 Apr 2024 12:09:04 -0400
Subject: [PATCH] [CUDA][HIP] Fix record layout on Windows
On windows, record
yxsamliu wrote:
> > Keeping layout in sync makes sense to me, but I'm completely unfamiliar
> > with the windows side.
> > @rnk is there anything else we need to worry about?
>
> I checked, and I think this routes everything over to the MS record layout
> builder, so it should be comprehensive
