[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2024-11-13 Thread Artem Belevich via cfe-commits
Artem-B wrote: While I'm not sure how concepts will work in CUDA in the end, I'm OK with fixing obviously wrong behaviors now, without potentially paining ourselves into a corner. The key issue in the example in https://godbolt.org/z/o7Wa68n9c seems to be that CUDA's context-aware overload res

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2024-11-13 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > Is this still relevant? Yes. The issue still exists and my arguments still hold https://github.com/llvm/llvm-project/pull/67721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2024-11-12 Thread Matt Arsenault via cfe-commits
arsenm wrote: Is this still relevant? https://github.com/llvm/llvm-project/pull/67721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-10-17 Thread Yaxun Liu via cfe-commits
@@ -176,3 +176,34 @@ Predefined Macros * - ``HIP_API_PER_THREAD_DEFAULT_STREAM`` - Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated. +C++20 Concepts with HIP and CUDA + + +In Clang, when working with HIP or CUDA, it's impor

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-10-16 Thread Yaxun Liu via cfe-commits
@@ -176,3 +176,34 @@ Predefined Macros * - ``HIP_API_PER_THREAD_DEFAULT_STREAM`` - Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated. +C++20 Concepts with HIP and CUDA + + +In Clang, when working with HIP or CUDA, it's impor

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-10-12 Thread Richard Smith via cfe-commits
@@ -176,3 +176,34 @@ Predefined Macros * - ``HIP_API_PER_THREAD_DEFAULT_STREAM`` - Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated. +C++20 Concepts with HIP and CUDA + + +In Clang, when working with HIP or CUDA, it's impor

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-10-12 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: ping https://github.com/llvm/llvm-project/pull/67721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-10-06 Thread Yaxun Liu via cfe-commits
@@ -176,3 +176,34 @@ Predefined Macros * - ``HIP_API_PER_THREAD_DEFAULT_STREAM`` - Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated. +C++20 Concepts with HIP and CUDA + + +In Clang, when working with HIP or CUDA, it's impor

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-10-04 Thread Artem Belevich via cfe-commits
@@ -176,3 +176,34 @@ Predefined Macros * - ``HIP_API_PER_THREAD_DEFAULT_STREAM`` - Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated. +C++20 Concepts with HIP and CUDA + + +In Clang, when working with HIP or CUDA, it's impor

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-10-04 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: ping https://github.com/llvm/llvm-project/pull/67721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-09-28 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/67721 >From ba151e83af264074303ccc1d8f4ecf853a4a153f Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 28 Sep 2023 14:48:28 -0400 Subject: [PATCH] [CUDA][HIP] Fix host/device context in concept Currently, c

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-09-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 720e3bacbd9fdba05645a4d621d43ad712c44df3 93c1086002a4a946ac2fc9066539733db750204f --

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Currently, constraints are checked in Sema::FinishTemplateArgumentDeduction, where the current function in ASTContext is set to the instantiated template function. When resolving functions for the constraints, clang assumes the caller is

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-09-28 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/67721 Currently, constraints are checked in Sema::FinishTemplateArgumentDeduction, where the current function in ASTContext is set to the instantiated template function. When resolving functions for the constraints,