[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-11-06 Thread Pankaj Dwivedi via cfe-commits
https://github.com/PankajDwivedi-25 closed https://github.com/llvm/llvm-project/pull/111650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-11-06 Thread Pankaj Dwivedi via cfe-commits
PankajDwivedi-25 wrote: Great, looks it is part of another bug propagated. Including fix path resolved the issue. Closing this PR now. Thank you for your feedback. https://github.com/llvm/llvm-project/pull/111650 ___ cfe-commits mailing list cfe-comm

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-11-04 Thread Artem Belevich via cfe-commits
Artem-B wrote: I'm saying is that whatever refers to the fatbin handle has to have the same idea about the name of that handle as the object file that provides that handle. For that both have to be compiled with the same `cuid`. Normally, it's clang driver that does that all under the hood. If

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-11-03 Thread Pankaj Dwivedi via cfe-commits
PankajDwivedi-25 wrote: Both are separate builds here. 'By Inconsistency' you mean both cases can not be present in same build? https://github.com/llvm/llvm-project/pull/111650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-11-01 Thread Artem Belevich via cfe-commits
Artem-B wrote: > now it is complaining about __hip_fatbin earlier it was > __hip_gpubin_handle_2ba9067058fbe93a. In both cases there's some sort of inconsistency in your build. Find the compilation which creates the object file which refers to the missing symbol, and then we can try figuring

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-11-01 Thread Pankaj Dwivedi via cfe-commits
PankajDwivedi-25 wrote: Looks like this issue is still reproducible in latest build. I'm wondering why then it disappeared in the previously. I'm seeing a minor difference now it is complaining about **__hip_fatbin** earlier it was **__hip_gpubin_handle_2ba9067058fbe93a**. > ld.lld: error: und

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-10-10 Thread Pankaj Dwivedi via cfe-commits
PankajDwivedi-25 wrote: > > > This does not seem to be the right fix. I tends to think the test > > > https://github.com/ROCm/hip-tests/tree/amd-staging/samples/2_Cookbook/16_assembly_to_executable > > > needs fix. Since it does not expect host-only compilation to use CUID, > > > it should add

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-10-10 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > > This does not seem to be the right fix. I tends to think the test > > https://github.com/ROCm/hip-tests/tree/amd-staging/samples/2_Cookbook/16_assembly_to_executable > > needs fix. Since it does not expect host-only compilation to use CUID, it > > should add `-fuse-cuid=non

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-10-10 Thread Pankaj Dwivedi via cfe-commits
PankajDwivedi-25 wrote: > This does not seem to be the right fix. I tends to think the test > https://github.com/ROCm/hip-tests/tree/amd-staging/samples/2_Cookbook/16_assembly_to_executable > needs fix. Since it does not expect host-only compilation to use CUID, it > should add `-fuse-cuid=non

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-10-09 Thread Artem Belevich via cfe-commits
Artem-B wrote: > This does not seem to be the right fix. I tends to think the test > https://github.com/ROCm/hip-tests/tree/amd-staging/samples/2_Cookbook/16_assembly_to_executable > needs fix. Since it does not expect host-only compilation to use CUID, it > should add `-fuse-cuid=none` to the

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-10-09 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: This does not seem to be the right fix. I tends to think the test https://github.com/ROCm/hip-tests/tree/amd-staging/samples/2_Cookbook/16_assembly_to_executable needs fix. Since it does not expect host-only compilation to use CUID, it should add `-fuse-cuid=none` to the host-o

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-10-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1312369afbeb2083094b3d34a88c346b22e86971 7fab0002d9febf440545043d8782d7243a03f17b --e

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Pankaj Dwivedi (PankajDwivedi-25) Changes build failure is observed in the hip test after patch #107483, which complains about a linking error. "/usr/bin/ld: /opt/rocm/share/hip/samples/2_Cookbook/16_ass

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-10-09 Thread Pankaj Dwivedi via cfe-commits
https://github.com/PankajDwivedi-25 created https://github.com/llvm/llvm-project/pull/111650 build failure is observed in the hip test after patch #107483, which complains about a linking error. "/usr/bin/ld: /opt/rocm/share/hip/samples/2_Cookbook/16_assembly_to_executable/build/square_asm.ou