[clang] [CMake] Fix variable name (PR #127967)

2025-02-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/11773 Here is the relevant piece of the build lo

[clang] [CMake] Fix variable name (PR #127967)

2025-02-20 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/127967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake] Fix variable name (PR #127967)

2025-02-20 Thread Madhur Amilkanthwar via cfe-commits
madhur13490 wrote: > > The fix is NOT correct. You need to enclose in quotes as @tstellar mentions > > in #126876 > > ` llvm_canonicalize_cmake_booleans` converts the string to an integer so you > don't need the quotes now that this function is called with the correct > variable. This is what

[clang] [CMake] Fix variable name (PR #127967)

2025-02-20 Thread Tom Stellard via cfe-commits
tstellar wrote: > The fix is NOT correct. You need to enclose in quotes as @tstellar mentions > in #126876 ` llvm_canonicalize_cmake_booleans` converts the string to an integer so you don't need the quotes now that this function is called with the correct variable. This is what the generated

[clang] [CMake] Fix variable name (PR #127967)

2025-02-20 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. LGTM. I confirmed this fixes the release build configuration. https://github.com/llvm/llvm-project/pull/127967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [CMake] Fix variable name (PR #127967)

2025-02-20 Thread Madhur Amilkanthwar via cfe-commits
madhur13490 wrote: Please merge this soon. This has broken our CI miserably and has blocked all our testing. Thanks! https://github.com/llvm/llvm-project/pull/127967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [CMake] Fix variable name (PR #127967)

2025-02-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Petr Hosek (petrhosek) Changes This was accidentaly introduced in #126876. --- Full diff: https://github.com/llvm/llvm-project/pull/127967.diff 1 Files Affected: - (modified) clang/utils/perf-training/CMakeLists.txt (+1-1) ``

[clang] [CMake] Fix variable name (PR #127967)

2025-02-19 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/127967 This was accidentaly introduced in #126876. >From 811f3ce860a5e544000166ccd06df3bb8cf5ec6b Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Thu, 20 Feb 2025 07:39:23 + Subject: [PATCH] [CMake] Fix variable