[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Farzon Lotfi (farzonl) Changes While clangCodeGenTargetBuiltins and clangCodeGenTargets are static libraries clangCodeGen is not and so this is creating a circular reference in the linux amdgpu-offload CIs on ubuntu and RHEL. rem

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

farzonl wrote: > I tried to build it locally and I got a series of 'undefined reference' > errors. Sorry, I will need to revert my approval. Attn. @jhuber6 > > Thanks Could you provide the failures you were seeing, specific build instructions, and platform you were doing this on. https://gi

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/133776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/133776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

https://github.com/asudarsa edited https://github.com/llvm/llvm-project/pull/133776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

asudarsa wrote: > > > @farzonl can you please revert the original commit? It seems to break > > > just any LLVM build, so I guess the CI testing of all new PRs should be > > > affected. > > > > > > I don't see it breaking any build in LLVM, just the amd offload ones. Al > > the Premerge test

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

vzakhari wrote: > > @farzonl can you please revert the original commit? It seems to break just > > any LLVM build, so I guess the CI testing of all new PRs should be affected. > > I don't see it breaking any build in LLVM, just the amd offload ones. Al the > Premerge tests also passed. I suspe

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

farzonl wrote: > @farzonl can you please revert the original commit? It seems to break just > any LLVM build, so I guess the CI testing of all new PRs should be affected. I don't see it breaking any build in LLVM, just the amd offload ones. Al the Premerge tests also passed. I suspect the `AM

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

vzakhari wrote: @farzonl can you please revert the original commit? It seems to break just any LLVM build, so I guess the CI testing of all new PRs should be affected. https://github.com/llvm/llvm-project/pull/133776 ___ cfe-commits mailing list cfe-c

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

https://github.com/asudarsa commented: I tried to build it locally and I got a series of 'undefined reference' errors. Sorry, I will need to revert my approval. Thanks https://github.com/llvm/llvm-project/pull/133776 ___ cfe-commits mailing list cfe-

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

https://github.com/asudarsa approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/133776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Farzon Lotfi (farzonl) Changes While clangCodeGenTargetBuiltins and clangCodeGenTargets are static libraries clangCodeGen is not and so this is creating a circular reference in the linux amdgpu-offload CIs on ubuntu and RHEL. removing th

[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)

https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/133776 While clangCodeGenTargetBuiltins and clangCodeGenTargets are static libraries clangCodeGen is not and so this is creating a circular reference in the linux amdgpu-offload CIs on ubuntu and RHEL. removing the c