[clang] [CIR] Upstream func args alloca handling (PR #129167)

2025-03-01 Thread Erich Keane via cfe-commits
@@ -52,6 +52,14 @@ class Address { elementType); } + Address(mlir::Value pointer, clang::CharUnits alignment) + : Address(pointer, +mlir::cast(pointer.getType()).getPointee(), erichkeane wrote: Got it, thanks for the clarifi

[clang] [CIR] Upstream func args alloca handling (PR #129167)

2025-02-28 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/129167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream func args alloca handling (PR #129167)

2025-02-28 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/129167 >From d1fa2629b5786befa8ca8f839cf948df4644d615 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Tue, 25 Feb 2025 16:52:18 -0800 Subject: [PATCH 1/2] [CIR] Upstream func args alloca handling This change adds

[clang] [CIR] Upstream func args alloca handling (PR #129167)

2025-02-28 Thread Andy Kaylor via cfe-commits
@@ -149,16 +153,49 @@ mlir::LogicalResult CIRGenFunction::declare(Address addr, const Decl *var, void CIRGenFunction::startFunction(GlobalDecl gd, QualType returnType, cir::FuncOp fn, cir::FuncType funcType, -

[clang] [CIR] Upstream func args alloca handling (PR #129167)

2025-02-28 Thread Andy Kaylor via cfe-commits
@@ -234,6 +273,29 @@ cir::FuncOp CIRGenFunction::generateCode(clang::GlobalDecl gd, cir::FuncOp fn, return fn; } +clang::QualType CIRGenFunction::buildFunctionArgList(clang::GlobalDecl gd, + FunctionArgList &args) { + con

[clang] [CIR] Upstream func args alloca handling (PR #129167)

2025-02-28 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. LGTM once the 'auto' problems are fixed. https://github.com/llvm/llvm-project/pull/129167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [CIR] Upstream func args alloca handling (PR #129167)

2025-02-28 Thread Andy Kaylor via cfe-commits
@@ -52,6 +52,14 @@ class Address { elementType); } + Address(mlir::Value pointer, clang::CharUnits alignment) + : Address(pointer, +mlir::cast(pointer.getType()).getPointee(), andykaylor wrote: The thing that's being cast is

[clang] [CIR] Upstream func args alloca handling (PR #129167)

2025-02-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This change adds support for collecting function arguments and storing them in alloca memory slots. --- Full diff: https://github.com/llvm/llvm-project/pull/129167.diff 10 Files Affected: - (modified) c

[clang] [CIR] Upstream func args alloca handling (PR #129167)

2025-02-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Andy Kaylor (andykaylor) Changes This change adds support for collecting function arguments and storing them in alloca memory slots. --- Full diff: https://github.com/llvm/llvm-project/pull/129167.diff 10 Files Affected: - (modified)

[clang] [CIR] Upstream func args alloca handling (PR #129167)

2025-02-27 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/129167 This change adds support for collecting function arguments and storing them in alloca memory slots. >From d1fa2629b5786befa8ca8f839cf948df4644d615 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Tue, 25 Fe