https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/140322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
andykaylor wrote:
> LGTM. Is there an easy to add a test for this? I understand sometimes it's
> hard, but just double checking.
The only thing I can think of would be a unit test that calculates folding set
IDs for a bunch of similar, but slightly different, function signatures to
verify tha
@@ -112,8 +112,16 @@ class CIRGenFunctionInfo final
// NOLINTNEXTLINE(readability-identifier-naming)
void Profile(llvm::FoldingSetNodeID &id) {
-id.AddBoolean(required.getOpaqueData());
-getReturnType().Profile(id);
+// It's unfortunate that we are looping over
https://github.com/el-ev approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/140322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes approved this pull request.
LGTM. Is there an easy to add a test for this? I understand sometimes it's
hard, but just double checking.
https://github.com/llvm/llvm-project/pull/140322
___
cfe-commits mailing list
cfe-c
@@ -112,8 +112,16 @@ class CIRGenFunctionInfo final
// NOLINTNEXTLINE(readability-identifier-naming)
void Profile(llvm::FoldingSetNodeID &id) {
-id.AddBoolean(required.getOpaqueData());
-getReturnType().Profile(id);
+// It's unfortunate that we are looping over
llvmbot wrote:
@llvm/pr-subscribers-clangir
Author: Andy Kaylor (andykaylor)
Changes
There was a problem introduced today where sometimes the CIR for functions with
no arguments would be generated with phantom arguments. This was causing
intermittent test failures.
The problem appears t
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andy Kaylor (andykaylor)
Changes
There was a problem introduced today where sometimes the CIR for functions with
no arguments would be generated with phantom arguments. This was causing
intermittent test failures.
The problem appears to
https://github.com/andykaylor created
https://github.com/llvm/llvm-project/pull/140322
There was a problem introduced today where sometimes the CIR for functions with
no arguments would be generated with phantom arguments. This was causing
intermittent test failures.
The problem appears to ha
