https://github.com/kyulee-com closed
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/NuriAmari approved this pull request.
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kyulee-com wrote:
I think I've addressed all the comments and the usage is fairly straightforward.
Can someone take another look?
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
NuriAmari wrote:
> Do you see or expect any issues with using distributed ThinLTO?
No seems good to me!
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
kyulee-com wrote:
@NuriAmari Do you see or expect any issues with using distributed ThinLTO?
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
jansvoboda11 wrote:
The options handling part LGTM, but I'll let others review the actual semantics
of this PR.
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
@@ -2753,6 +2753,31 @@ void tools::addMachineOutlinerArgs(const Driver &D,
addArg(Twine("-enable-machine-outliner=never"));
}
}
+
+ auto *CodeGenDataGenArg =
+ Args.getLastArg(options::OPT_fcodegen_data_generate_EQ);
+ auto *CodeGenDataUseArg = Args.getLastAr
@@ -2753,6 +2753,33 @@ void tools::addMachineOutlinerArgs(const Driver &D,
addArg(Twine("-enable-machine-outliner=never"));
}
}
+
+ auto *CodeGenDataGenArg =
+ Args.getLastArg(options::OPT_fcodegen_data_generate,
kyulee-com wrote:
Thanks for
@@ -1894,6 +1894,18 @@ def fprofile_selected_function_group :
Visibility<[ClangOption, CC1Option]>, MetaVarName<"">,
HelpText<"Partition functions into N groups using -fprofile-function-groups
and select only functions in group i to be instrumented. The valid range is 0
to
kyulee-com wrote:
> Can we add some documentation to
> https://github.com/llvm/llvm-project/blob/main/clang/docs/UsersManual.rst?
> This could also be a separate PR.
>
> LGTM, but I want to give others a chance to review.
Added some documentation, and simplify the flag use by removing the dir
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/90304
>From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 26 Apr 2024 12:58:54 -0700
Subject: [PATCH 1/6] [CGData] Clang Optinos
---
clang/include/clang/Driver/Opt
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/90304
>From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 26 Apr 2024 12:58:54 -0700
Subject: [PATCH 1/6] [CGData] Clang Optinos
---
clang/include/clang/Driver/Opt
@@ -2753,6 +2753,33 @@ void tools::addMachineOutlinerArgs(const Driver &D,
addArg(Twine("-enable-machine-outliner=never"));
}
}
+
+ auto *CodeGenDataGenArg =
+ Args.getLastArg(options::OPT_fcodegen_data_generate,
jansvoboda11 wrote:
Since `fc
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/90304
>From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 26 Apr 2024 12:58:54 -0700
Subject: [PATCH 1/4] [CGData] Clang Optinos
---
clang/include/clang/Driver/Opt
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/90304
>From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 26 Apr 2024 12:58:54 -0700
Subject: [PATCH 1/4] [CGData] Clang Optinos
---
clang/include/clang/Driver/Opt
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/90304
>From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 26 Apr 2024 12:58:54 -0700
Subject: [PATCH 1/4] [CGData] Clang Optinos
---
clang/include/clang/Driver/Opt
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/90304
>From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 26 Apr 2024 12:58:54 -0700
Subject: [PATCH 1/3] [CGData] Clang Optinos
---
clang/include/clang/Driver/Opt
@@ -1894,6 +1894,18 @@ def fprofile_selected_function_group :
Visibility<[ClangOption, CC1Option]>, MetaVarName<"">,
HelpText<"Partition functions into N groups using -fprofile-function-groups
and select only functions in group i to be instrumented. The valid range is 0
to
https://github.com/ellishg commented:
Can we add some documentation to
https://github.com/llvm/llvm-project/blob/main/clang/docs/UsersManual.rst? This
could also be a separate PR.
LGTM, but I want to give others a chance to review.
https://github.com/llvm/llvm-project/pull/90304
_
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/90304
>From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 26 Apr 2024 12:58:54 -0700
Subject: [PATCH 1/2] [CGData] Clang Optinos
---
clang/include/clang/Driver/Opt
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/90304
>From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 26 Apr 2024 12:58:54 -0700
Subject: [PATCH 1/3] [CGData] Clang Optinos
---
clang/include/clang/Driver/Opt
@@ -1894,6 +1894,18 @@ def fprofile_selected_function_group :
Visibility<[ClangOption, CC1Option]>, MetaVarName<"">,
HelpText<"Partition functions into N groups using -fprofile-function-groups
and select only functions in group i to be instrumented. The valid range is 0
to
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Kyungwoo Lee (kyulee-com)
Changes
This adds new Clang flags to support codegen (CG) data:
- `-fcodegen-data-generate{=path}`: This flag passes `-codegen-data-generate`
as a boolean to the LLVM backend, causing the raw CG data to be
https://github.com/kyulee-com ready_for_review
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/90304
>From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 26 Apr 2024 12:58:54 -0700
Subject: [PATCH] [CGData] Clang Optinos
---
clang/include/clang/Driver/Options
28 matches
Mail list logo
