https://github.com/jathu updated https://github.com/llvm/llvm-project/pull/67626
>From 20d9ca99fbf11868a5816df217b2aad09e079fb6 Mon Sep 17 00:00:00 2001
From: jathu
Date: Wed, 27 Sep 2023 18:01:19 -0700
Subject: [PATCH] [clang-tidy][bazel] Include builtin headers with clang-tidy
---
.../clang-
https://github.com/jathu updated https://github.com/llvm/llvm-project/pull/67626
>From 20d9ca99fbf11868a5816df217b2aad09e079fb6 Mon Sep 17 00:00:00 2001
From: jathu
Date: Wed, 27 Sep 2023 18:01:19 -0700
Subject: [PATCH] [clang-tidy][bazel] Include builtin headers with clang-tidy
---
.../clang-
jathu wrote:
@aeubanks @rnk
> issues with 2: relies on bazel paths, i.e. this puts the symlink at
> bazel-bin/external/llvm-project/clang-tools-extra/ which happens to be two
> directories up from
> bazel-bin/external/llvm-project/clang-tools-extra/clang-tidy/clang-tidy
I also think this is
aeubanks wrote:
my worry about baking in the resource dir for the bazel build is that it'll be
tied to the bazel build directory structure implementation details, so it's
likely that you can't copy the binaries around and create a toolchain out of
it. if bazel users don't care about this, then
rnk wrote:
I think option 1 isn't really a permanent solution. We have lots of clang tools
that need to find the resource directory, and it should happen automatically.
For option 2, we'd have to reimplement that for every other clang tool that
needs to find resources, like LLD as well.
Shoul
aeubanks wrote:
I think there are two approaches to this problem
1) point `-resource-dir` to the directory where the headers are, e.g.
`clang-tidy --extra-arg=-resource-dir=path/to/include`
2) mirror the CMake binary/include layout (this patch)
issues with 1: extra argument to pass, have to fig
https://github.com/jathu updated https://github.com/llvm/llvm-project/pull/67626
>From 20d9ca99fbf11868a5816df217b2aad09e079fb6 Mon Sep 17 00:00:00 2001
From: jathu
Date: Wed, 27 Sep 2023 18:01:19 -0700
Subject: [PATCH] [clang-tidy][bazel] Include builtin headers with clang-tidy
---
.../clang-
https://github.com/jathu updated https://github.com/llvm/llvm-project/pull/67626
>From 20d9ca99fbf11868a5816df217b2aad09e079fb6 Mon Sep 17 00:00:00 2001
From: jathu
Date: Wed, 27 Sep 2023 18:01:19 -0700
Subject: [PATCH] [clang-tidy][bazel] Include builtin headers with clang-tidy
---
.../clang-
