[clang] [AST] Remove clang/AST/CommentDiagnostic.h (PR #117499)

https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/117499 >From e9427756de508dc386a10ee9ee19cc4733a40465 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 24 Nov 2024 09:14:54 -0800 Subject: [PATCH 1/2] [AST] Remove clang/AST/CommentDiagnostic.h Since: c

[clang] [AST] Remove clang/AST/CommentDiagnostic.h (PR #117499)

https://github.com/AaronBallman approved this pull request. LGTM modulo the module question. https://github.com/llvm/llvm-project/pull/117499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [AST] Remove clang/AST/CommentDiagnostic.h (PR #117499)

@@ -111,7 +111,6 @@ module Clang_Diagnostics { module All { header "clang/Basic/AllDiagnostics.h" export * } module Analysis { textual header "clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def" } module AST { header "clang/AST/ASTDiagnostic.h" export * } - module Com

[clang] [AST] Remove clang/AST/CommentDiagnostic.h (PR #117499)

https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/117499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Remove clang/AST/CommentDiagnostic.h (PR #117499)

@@ -111,7 +111,6 @@ module Clang_Diagnostics { module All { header "clang/Basic/AllDiagnostics.h" export * } module Analysis { textual header "clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def" } module AST { header "clang/AST/ASTDiagnostic.h" export * } - module Com

[clang] [AST] Remove clang/AST/CommentDiagnostic.h (PR #117499)

https://github.com/Sirraide approved this pull request. Yeah, I think we can remove this header at this point. I do have a question about the modulemap though. https://github.com/llvm/llvm-project/pull/117499 ___ cfe-commits mailing list cfe-commits@l

[clang] [AST] Remove clang/AST/CommentDiagnostic.h (PR #117499)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Since: commit d076608d58d1ec55016eb747a995511e3a3f72aa Author: Richard Trieu Date: Sat Dec 8 05:05:03 2018 + clang/AST/CommentDiagnostic.h has been forwarding to clang/B

[clang] [AST] Remove clang/AST/CommentDiagnostic.h (PR #117499)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/117499 Since: commit d076608d58d1ec55016eb747a995511e3a3f72aa Author: Richard Trieu Date: Sat Dec 8 05:05:03 2018 + clang/AST/CommentDiagnostic.h has been forwarding to clang/Basic/DiagnosticParse.