[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-19 Thread Andrew Stubbs via cfe-commits
ams-cs wrote: GCC deprecation done: [commit details](https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=56ed1055b2f40ac162ae8d382280ac07a33f789f;hp=8f4bbdc28df6e87a7ad5ec5ca191a7a836a4f016). https://github.com/llvm/llvm-project/pull/67118 ___ cfe-commi

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-18 Thread Andrew Stubbs via cfe-commits
ams-cs wrote: We're discussing replacing the devices with something newer, but there are practical and business issues with that, so no hard plans. Sorry. I'm leaning toward officially deprecating Fiji for GCC 14, and remove it from GCC 15 (so, sometime next year). If we can get these devices

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-18 Thread Pierre van Houtryve via cfe-commits
Pierre-vh wrote: I don't mind reverting, but do you have a timeline for removal of that device? v3 has been deprecated for a while, AFAIK. https://github.com/llvm/llvm-project/pull/67118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-18 Thread Andrew Stubbs via cfe-commits
ams-cs wrote: @Pierre-vh Can we undo this please? Just for now. This broke the GCC build (which uses llvm-mc) because we still use v3 like @tob2 said. I don't know that anyone is using Fiji in production, but it's still a good proportion of what we have in our compiler test farm. As far as I

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-18 Thread Tobias Burnus via cfe-commits
tob2 wrote: > V3 has been deprecated for a while as well, so it can safely be removed We are using v3 for (better) backward compatibility with the older gfx803 / fiji cards (GCN GFX8 (Volcanic Islands (VI))) — thus, this commit on Monday broke our tester for gfx803 / fiji cards :-( However, f

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-15 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh closed https://github.com/llvm/llvm-project/pull/67118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-15 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/67118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-13 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. LGTM. Thanks https://github.com/llvm/llvm-project/pull/67118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-10 Thread Konstantin Zhuravlyov via cfe-commits
https://github.com/kzhuravl approved this pull request. This LGTM. But wait a couple of days to see if @arsenm or @yxsamliu have any objections? https://github.com/llvm/llvm-project/pull/67118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-09-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 22e2b805ef3c4caa971fad3656976b6e0017aff3 73934bfbd4231a5abfaad9690977af323be7e9ba --

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes V3 has been deprecated for a while as well, so it can safely be removed like V2 was removed. - [Clang] Set minimum code object version to 4 - [lld] Fix tests using code object v3 - Remove code object V3 from the AMDGPU backend, and delete