Re: [PATCH] Windows support for ObjC DLLIMPORT

2016-04-05 Thread Aaron Ballman via cfe-commits
On Mon, Apr 4, 2016 at 3:34 PM, Wes Witt via cfe-commits wrote: > Please accept this diff as a change to support dllimport of objective c > interfaces on windows. I’ve included a new test and changes to an existing > test as well. All clang tests pass on Linux & Windows. This change is > required

Re: [PATCH] Windows support for ObjC DLLIMPORT

2016-04-04 Thread Reid Kleckner via cfe-commits
In addition to the Sema tests, this change needs tests in CodeGenObjC to show where the attribute is applied in the IR. --- a/lib/CodeGen/CGBlocks.cpp +++ b/lib/CodeGen/CGBlocks.cpp @@ -2334,5 +2334,9 @@ llvm::Constant *CodeGenModule::getNSConcreteStackBlock() {

[PATCH] Windows support for ObjC DLLIMPORT

2016-04-04 Thread Wes Witt via cfe-commits
Please accept this diff as a change to support dllimport of objective c interfaces on windows. I've included a new test and changes to an existing test as well. All clang tests pass on Linux & Windows. This change is required for Microsoft's use of the clang compiler in support of objective c on