Re: [PATCH] SemaCXX: Support templates in availability attributes

2016-02-26 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Feb-24, at 10:01, Aaron Ballman wrote: > > On Tue, Feb 23, 2016 at 6:39 PM, Duncan P. N. Exon Smith > wrote: >> >>> On 2016-Feb-23, at 11:18, Aaron Ballman wrote: >>> >>> On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote: This patch looks good to me. But I am not sure if Aaro

Re: [PATCH] SemaCXX: Support templates in availability attributes

2016-02-24 Thread Aaron Ballman via cfe-commits
On Tue, Feb 23, 2016 at 6:39 PM, Duncan P. N. Exon Smith wrote: > >> On 2016-Feb-23, at 11:18, Aaron Ballman wrote: >> >> On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote: >>> This patch looks good to me. But I am not sure if Aaron has any comment. >>> >>> On Feb 22, 2016, at 6:19 PM, Duncan P.

Re: [PATCH] SemaCXX: Support templates in availability attributes

2016-02-23 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Feb-23, at 11:18, Aaron Ballman wrote: > > On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote: >> This patch looks good to me. But I am not sure if Aaron has any comment. >> >> On Feb 22, 2016, at 6:19 PM, Duncan P. N. Exon Smith >> wrote: >> >> >> On 2016-Feb-22, at 17:24, Manman

Re: [PATCH] SemaCXX: Support templates in availability attributes

2016-02-23 Thread Aaron Ballman via cfe-commits
On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote: > This patch looks good to me. But I am not sure if Aaron has any comment. > > On Feb 22, 2016, at 6:19 PM, Duncan P. N. Exon Smith > wrote: > > > On 2016-Feb-22, at 17:24, Manman Ren wrote: > > > > On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon

Re: [PATCH] SemaCXX: Support templates in availability attributes

2016-02-23 Thread Manman Ren via cfe-commits
This patch looks good to me. But I am not sure if Aaron has any comment. > On Feb 22, 2016, at 6:19 PM, Duncan P. N. Exon Smith > wrote: > >> >> On 2016-Feb-22, at 17:24, Manman Ren wrote: >> >> >> >>> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon Smith >>> wrote: >>> >>> This patch add

Re: [PATCH] SemaCXX: Support templates in availability attributes

2016-02-22 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Feb-22, at 17:24, Manman Ren wrote: > > > >> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon Smith >> wrote: >> >> This patch adds support for templates in availability attributes. >> - If the context for an availability diagnostic is a >> `FunctionTemplateDecl`, look through it t

Re: [PATCH] SemaCXX: Support templates in availability attributes

2016-02-22 Thread Manman Ren via cfe-commits
> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon Smith > wrote: > > This patch adds support for templates in availability attributes. > - If the context for an availability diagnostic is a >`FunctionTemplateDecl`, look through it to the `FunctionDecl`. > AvailabilityResult Decl::getAvail

[PATCH] SemaCXX: Support templates in availability attributes

2016-02-08 Thread Duncan P. N. Exon Smith via cfe-commits
This patch adds support for templates in availability attributes. - If the context for an availability diagnostic is a `FunctionTemplateDecl`, look through it to the `FunctionDecl`. - Add `__has_feature(attribute_availability_in_templates)`. Is there anything else I should be testing to be