Re: [PATCH] Proper detection and handling of RHEL and variants

2016-05-09 Thread Rafael Espíndola via cfe-commits
r268914. Thanks, Rafael On 26 March 2016 at 20:35, Michael Lampe wrote: > New patch attached. I've also removed RHEL4 which is now four years past EOL > and certainly incapable of building or running any recent version of > llvm/clang. > > -Michael > > > Rafael Espíndola wrote: >> >> - if (IsRe

Re: [PATCH] Proper detection and handling of RHEL and variants

2016-03-26 Thread Michael Lampe via cfe-commits
New patch attached. I've also removed RHEL4 which is now four years past EOL and certainly incapable of building or running any recent version of llvm/clang. -Michael Rafael Espíndola wrote: - if (IsRedhat(Distro)) + if (Distro == Fedora || Distro == RHEL7) RHEL8 will probably use --no-add

Re: [PATCH] Proper detection and handling of RHEL and variants

2016-03-26 Thread Rafael Espíndola via cfe-commits
- if (IsRedhat(Distro)) + if (Distro == Fedora || Distro == RHEL7) RHEL8 will probably use --no-add-needed. Can you change this to "if (IsRedhat(Distro) && !old_rhel_distro) "? Cheers, Rafael On 22 March 2016 at 22:07, Michael Lampe via cfe-commits wrote: > - Don't consider "/etc/lsb-releas

[PATCH] Proper detection and handling of RHEL and variants

2016-03-23 Thread Michael Lampe via cfe-commits
- Don't consider "/etc/lsb-release" to be Ubuntu only. - Detect SL, too. - Only add "--no-add-needed" for RHEL7 (or Fedora), not for RHEL6 (that's what the compilers shipped with RHEL do). --- a/tools/clang/lib/Driver/ToolChains.cpp 2015-09-02 04:26:13.266233474 +0200 +++ b/tools/clang/lib