Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

2017-02-28 Thread Aaron Ballman via cfe-commits
On Fri, Feb 24, 2017 at 8:24 AM, Marcwell Helpdesk wrote: > > As interesting the subject of pluggable attributes may be could we please > drop that discussion and focus on the intention of and what the patch > actually does? Two revisions of the patch have been supplied and both should > reason

Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

2017-02-25 Thread Marcwell Helpdesk via cfe-commits
As interesting the subject of pluggable attributes may be could we please drop that discussion and focus on the intention of and what the patch actually does? Two revisions of the patch have been supplied and both should reasonable not cause any controversy since they only enriches an already e

Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

2017-02-21 Thread Aaron Ballman via cfe-commits
On Tue, Feb 14, 2017 at 6:05 AM, Marcwell Helpdesk wrote: > The intention of the patch is to extend the functionality of annotations > while utilizing existing infrastructure in the AST and IR as much as > possible. Annotations are indeed a general purpose solution, sufficient for > many use cases

Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

2017-02-21 Thread Marcwell Helpdesk via cfe-commits
Friendly ping. > On 14 feb 2017, at 12:05, Marcwell Helpdesk wrote: > > The intention of the patch is to extend the functionality of annotations > while utilizing existing infrastructure in the AST and IR as much as > possible. Annotations are indeed a general purpose solution, sufficient for

Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

2017-02-14 Thread Marcwell Helpdesk via cfe-commits
The intention of the patch is to extend the functionality of annotations while utilizing existing infrastructure in the AST and IR as much as possible. Annotations are indeed a general purpose solution, sufficient for many use cases, and a complement, not mutual exclusive to pluggable attributes. A

Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

2017-02-09 Thread Aaron Ballman via cfe-commits
On Sat, Feb 4, 2017 at 8:26 AM, Marcwell Helpdesk via cfe-commits wrote: > Many plugins/tools could benefit from having a generic way for communicating > control directives directly from the source code to itself (via the AST) when > acting, for example, as source code transformers, generators,

Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

2017-02-09 Thread Marcwell Helpdesk via cfe-commits
Friendly ping. > On 4 feb 2017, at 14:26, Marcwell Helpdesk wrote: > > Many plugins/tools could benefit from having a generic way for communicating > control directives directly from the source code to itself (via the AST) when > acting, for example, as source code transformers, generators, co

[PATCH] Improved plugin/tool support by expanding an existing attribute

2017-02-04 Thread Marcwell Helpdesk via cfe-commits
Many plugins/tools could benefit from having a generic way for communicating control directives directly from the source code to itself (via the AST) when acting, for example, as source code transformers, generators, collectors and the like. Attributes are a suitable way of doing this but most a