[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

2021-04-07 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8ac5e440615d: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

2021-04-07 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D6#2673276 , @sylvestre.ledru wrote: > To understand better, we will be fixing a bug from 2015, correct? Yes. In D6#2674407 , @arichardson wrote: > I believe adding the defaul

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

2021-04-07 Thread Stephen Hines via Phabricator via cfe-commits
srhines added a comment. Adding Dan as an FYI. While this doesn't impact Android platform or regular NDK users, I suppose that someone could have some esoteric build rules that are relying on this, but they should probably be more explicit about what they're running in those cases anyways. Re

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

2021-04-07 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers accepted this revision. nickdesaulniers added a comment. I don't foresee this affecting Linux kernel builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 _

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

2021-04-07 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. I believe adding the default triple is causing the wrong linker to be selected for me when compiling with -m32, so I'd be happy for this code to be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ http

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

2021-04-07 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM AFAIK the MIPS LLVM-based toolchain mentioned in D13340 have not been implemented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

2021-04-06 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. To understand better, we will be fixing a bug from 2015, correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___ cfe-commits

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

2021-04-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: atanasyan, doko, nathanchance, nickdesaulniers, sylvestre.ledru, vkalintiris. Herald added subscribers: arichardson, sdardis. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D