[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

rnk added a comment. In D4#2706515 , @Holman wrote: > Can someone help me get this checked in? Sure, I went ahead and pushed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77357208c46a: [CodeView] Add CodeView support for PGO debug information (authored by Holman, committed by rnk). Repository: rG LLVM Github Monorep

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman added a comment. Can someone help me get this checked in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 __

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman updated this revision to Diff 336497. Holman added a comment. Fix clang-format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 Files: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp llvm/tes

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman updated this revision to Diff 336274. Holman set the repository for this revision to rG LLVM Github Monorepo. Holman added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 Files:

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

rnk added a comment. Seems reasonable, but we still need a small IR test. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:807 // TODO: Figure out which other flags need to be set. + if (MMI->getModule()->getProfileSummary(/* IsCS */ false) != nullptr) { +Flag

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman updated this revision to Diff 336223. Holman added a comment. Get PGO info from Module instead of adding new field to debug info. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 Files: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp Ind

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman added a comment. In D4#2677566 , @rnk wrote: > IMO it's best to avoid adding fields to DICompileUnit if at all possible. > It's the "god object" / "katamari damacy" of module debug info. Is there > something about the IR module that indicates

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

rnk added a comment. IMO it's best to avoid adding fields to DICompileUnit if at all possible. It's the "god object" / "katamari damacy" of module debug info. Is there something about the IR module that indicates if PGO data is present or not? We could check that instead. I looked, but I wasn't

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

akhuang added a comment. think this looks good overall; maybe it should also have an IR to codeview test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 ___ cfe-

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman created this revision. Herald added subscribers: dexonsmith, wenlei, hiraditya. Holman requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change adds debug information about whether PGO is being used or not. Micr