This revision was automatically updated to reflect the committed changes.
aganea marked an inline comment as done.
Closed by commit rG8fbc05acd553: [Windows] Add test coverage for line endings
when rewriting includes (authored by aganea).
Changed prior to commit:
https://reviews.llvm.org/D99973
aganea marked an inline comment as done.
aganea added inline comments.
Comment at: clang/test/Frontend/rewrite-includes-macros.cpp:15
+}
\ No newline at end of file
mstorsjo wrote:
> I guess the missing newline at end of file isn't one of the aspects that
> nee
abhina.sreeskantharajan accepted this revision.
abhina.sreeskantharajan added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for adding a testcase!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99973/new/
https://reviews.l
mstorsjo added a comment.
Not very familiar with the feature, but from the linked discussion it looks
sensible to me, so +1, I can give a formal stamp a bit later if nobody else
does.
Comment at: clang/test/Frontend/rewrite-includes-macros.cpp:15
+}
\ No newline at end of fil
aganea created this revision.
aganea added reviewers: abhina.sreeskantharajan, rnk, amccarth, MaskRay,
mstorsjo.
aganea requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Validate that we properly generating a single line ending on Windows wh
