[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

2021-04-12 Thread Sven van Haastregt via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG731bf28a6092: [OpenCL] Accept .rgba in OpenCL 3.0 (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D99969?vs=335557&id=3367

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

2021-04-07 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added a comment. In D99969#2671931 , @Anastasia wrote: > The code formating check reported an issue though... My bad, will fix before committing. Comment at: clang/lib/Sema/SemaExprMember.cpp:343 if (HasRGBA || (*compStr &&

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

2021-04-07 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov added a comment. Thanks for working on this! Looks good to me in general. I have a small comment. Comment at: clang/lib/Sema/SemaExprMember.cpp:343 if (HasRGBA || (*compStr && IsRGBA(*compStr))) { - if (S.getLangOpts().OpenCL && S.getLangOpts().OpenCLVersion

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

2021-04-06 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! The code formating check reported an issue though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99969/new/ https://revie

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

2021-04-06 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh created this revision. svenvh added reviewers: Anastasia, azabaznov. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. The .rgba vector component accessors are supported in OpenCL C 3.0.