[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

2021-05-04 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 abandoned this revision. Ericson2314 added a comment. D101497 is more safe/conservative and gets the job done to prepare for`GnuInstallDirs`. Closing in favor of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

2021-04-06 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 added a comment. In D99860#2670359 , @phosek wrote: > I'm worried that overriding `CMAKE_INSTALL_PREFIX` is going to break the > runtimes build where we build compiler-rt, libcxx, libcxxabi, libunwind in a > single CMake build, and compiler-r

[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

2021-04-06 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. I'm worried that overriding `CMAKE_INSTALL_PREFIX` is going to break the runtimes build where we build compiler-rt, libcxx, libcxxabi, libunwind in a single CMake build, and compiler-rt always comes first see https://github.com/llvm/llvm-project/blob/98742e42fc50f58d3f2d

[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

2021-04-04 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. It turns out we don't neeed to remove `clang/runtime` to make this work, as @phosek thou