This revision was automatically updated to reflect the committed changes.
jyu2 marked an inline comment as done and an inline comment as not done.
Closed by commit rG7078ef472250: [OPENMP51]Initial support for nocontext
clause. (authored by jyu2).
Repository:
rG LLVM Github Monorepo
CHANGES SI
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99848/new/
https://reviews.llvm.org/D99848
___
c
jyu2 added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14908
llvm::MapVector Captures;
+ ValExpr = tryBuildCapture(*this, ValExpr, Captures).get();
HelperValStmt = buildPreInits(Context, Captures);
ABataev wrote:
> This must be f
jyu2 updated this revision to Diff 335272.
jyu2 added a comment.
Fix formatting problem and address Alexey's comment. Thanks Alexey for the
review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99848/new/
https://reviews.llvm.org/D99848
Files:
ABataev added a comment.
Formatting
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14908
llvm::MapVector Captures;
+ ValExpr = tryBuildCapture(*this, ValExpr, Captures).get();
HelperValStmt = buildPreInits(Context, Captures);
This must be fixed in
jyu2 created this revision.
jyu2 added reviewers: mikerice, ABataev, jdoerfert.
Herald added subscribers: arphaman, guansong, yaxunl.
Herald added a reviewer: sscalpone.
jyu2 requested review of this revision.
Herald added a subscriber: sstefan1.
Herald added projects: clang, LLVM.
Added basic par
