[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

2021-04-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Committed in 4be8a26951da9a6e04de327b38dd158f4c8e3280 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99809/new/ https://reviews.llvm.org/D99809 _

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

2021-04-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Accepting on my own authority so I can close in a moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99809/new/ https://reviews.llvm.org/D99809 _

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

2021-04-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman updated this revision to Diff 335021. aaron.ballman added a comment. Correcting lint warnings, adding documentation for the new feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99809/new/ https://reviews.llvm.org/D99809 Files: clang/docs/InternalsManual.rst clan

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

2021-04-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. @rsmith -- I am posting the review so that I can see how the CI pipeline likes the functionality (because this impacts so many different attributes), but I intend to commit it on my own authority once CI passes. Feel free to review it if you'd like and I'll addres

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

2021-04-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. aaron.ballman requested review of this revision. Herald added a project: clang. Currently, when one or more attributes are mutually exclusive, the developer adding the attribute has to manually emit diagnostics. In pract