[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG803b79221edf: [SemaObjC] Fix a -Wbridge-cast false-positive (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Gith

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. I agree with you. If it's not going to work, maybe there should have been a warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99661/new/ https://reviews.llvm.org/D99661 ___

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

erik.pilkington updated this revision to Diff 334801. erik.pilkington added a comment. In D99661#2662601 , @ahatanak wrote: > Should we try to restore the behavior prior to > https://reviews.llvm.org/rG09abecef7bbfda18d34f046954eaa4d491062839 as much > a

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

ahatanak added a comment. I see a warning when I compile the following (contrived) example: typedef const struct __attribute__((objc_bridge(NSError))) __CFString * CFStringRef; extern "C" { typedef const struct __attribute__((objc_bridge(NSString))) __CFString * CFStringRef; }

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, ahatanak. erik.pilkington requested review of this revision. Clang used to emit a bad -Wbridge-cast diagnostic on the cast in the attached test. This was because, after 09abecef7