[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. > Could you explain why -debug-pass-manager doesn't fit your use case? I wanted to have something similar to -debug-pass=Structure, because the above is too verbose and lacks identation. What's the problem with this one, anyway? Repository: rG LLVM Github Monorepo

[PATCH] D99599: [NewPM] Add an option to dump pass structure

aeubanks added a comment. In D99599#2735582 , @evgeny777 wrote: >> I've already run into having to update these two golden file tests twice > > I think you can just reduce the tests. No need to revert the entire change, > unless there is a replacement for

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. > I've already run into having to update these two golden file tests twice I think you can just reduce the tests. No need to revert the entire change, unless there is a replacement for it (D101797 is not) Repository: rG LLVM Gith

[PATCH] D99599: [NewPM] Add an option to dump pass structure

aeubanks added a comment. I've already run into having to update these two golden file tests twice, we really shouldn't be having multiple types of golden file tests for the same thing in different locations and with different formats. I'd like to revert this change. Perhaps something like htt

[PATCH] D99599: [NewPM] Add an option to dump pass structure

aeubanks added a comment. As you said in the description, this overlaps a lot with -debug-pass-manager. What exactly is too verbose with the existing debug logging? I'd strongly prefer to have this consolidated into one pass instrumentation rather than two. Having a new pipeline test is very te

[PATCH] D99599: [NewPM] Add an option to dump pass structure

phosek added a comment. In D99599#2728092 , @evgeny777 wrote: > Should be fixed with `c81ec19fba27ec` Thank you, our builders went green after that change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9959

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. Should be fixed with `c81ec19fba27ec` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99599/new/ https://reviews.llvm.org/D99599 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D99599: [NewPM] Add an option to dump pass structure

phosek added a comment. It looks like the `BarrierNoop` pass is inserted under `-O0` when any extension is registered . We enable Polly in our toolchain so tha

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. Output from `clang -flegacy-pass-manager -fdebug-pass-structure -O0 -S -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c -o /dev/null 2>&1`: Pass Arguments: -tti -targetlibinfo Target Transform Information Target Library Information

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. In D99599#2726252 , @evgeny777 wrote: > @haowei What are LLVM configuration options? Also please send output from > > /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -flegacy-pass-manager > -fdebug-pass-structure -O0 -S -emit-llvm

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. Hm ... I see BarrierNoop pass being added before `annotation-remarks`. Why's that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99599/new/ https://reviews.llvm.org/D99599 ___

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. @haowei What are LLVM configuration options? Also please send output from /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -flegacy-pass-manager -fdebug-pass-structure -O0 -S -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c -o /dev/null

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. We are seeing test failures in our builders with message after your patch. Could you take a look and fix this unit test please? FAIL: Clang :: Driver/debug-pass-structure.c (6773 of 27894) TEST 'Clang :: Driver/debug-pass-structure.c' FAILED

[PATCH] D99599: [NewPM] Add an option to dump pass structure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a0283d0d23c: [NewPM] Add an option to dump pass structure (authored by evgeny777). Herald added a project: clang. Herald added a subscriber: cfe-com